Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix #150 : de-duplicate items in bodhi conglomerator #296

Merged
merged 1 commit into from Oct 28, 2014

Conversation

codenamesubho
Copy link
Contributor

Removing duplicate items in list_to_series function.

fedora-infra/fedmsg_meta_fedora_infrastructure#150

@codenamesubho
Copy link
Contributor Author

@ralphbean : Please review the code when you have time.

@ralphbean
Copy link
Contributor

That will totally do it, @ghost-script. Thanks!

May I make one request? Can you change it from items=list(set(items)) to items = list(set(items))? The spaces are suggested by PEP8.

@ralphbean
Copy link
Contributor

(And that reference to pep8 should be mentioned in our best practices document)

@ralphbean
Copy link
Contributor

Great. Thank you!

ralphbean added a commit that referenced this pull request Oct 28, 2014
BugFix #150 : de-duplicate items in bodhi conglomerator
@ralphbean ralphbean merged commit 0a90529 into fedora-infra:develop Oct 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants