Provide more info when crl-check fails. #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -157,7 +157,11 @@ def fail(reason): | |||
| for line in crl.as_text().split('\n') | |||
| if 'Serial Number:' in line] | |||
| if cert.get_serial_number() in revoked_serials: | |||
| return fail("X509 certificate is in the Revocation List (CRL)") | |||
| subject = cert.get_subject() | |||
| signer = subject.get_entries_by_nid(subject.nid['CN'])[0]\ | |||
There was a problem hiding this comment.
Are we sure we'll always have a 'CN' containing at least 1 entry?
There was a problem hiding this comment.
Hm, not always.
- For our fedora infra certs, yes.
- For any system that is using the
routing_policy, yes. It requires CNs to figure things out.
But they're not strictly necessary, so this code should be modified to be more careful.
There was a problem hiding this comment.
OK, a73c236 should take care of that.
| return fail("X509 certificate is in the Revocation List (CRL)") | ||
| subject = cert.get_subject() | ||
| if subject.nid.get('CN'): | ||
| signer = subject.get_entries_by_nid(subject.nid['CN'])[0]\ |
There was a problem hiding this comment.
Still nitpicking, can the first element in the list be None?
There was a problem hiding this comment.
get_entries_by_nid calls getitem which gets things out of this 'stack' collection that communicates with the underlying openssl lib...
|
Cool, 👍 for me then :) |
|
Thanks :) |
ralphbean
added a commit
that referenced
this pull request
Aug 17, 2014
Provide more info when crl-check fails.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.