Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the GNOME backend to rely on the cache.json if present #118

Merged
merged 7 commits into from Mar 24, 2015

Conversation

pypingou
Copy link
Member

fixes #54

This make the code more readable by isolating it.
We first try to retrieve the versions using the cache.json and if that
fails, then we go back to using the regex as we did before.
- Call the URL properly
- Save the output returned by use_gnome_cache_json and use_gnome_regex
  so that it can be returned
try:
# First try to get the version by using the cache.json file
output = use_gnome_cache_json(project)
except Exception:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we log a warning here about the details of the exception? Otherwise, if the cache/json stuff breaks, we'll never know.

@ralphbean
Copy link
Contributor

Other than the request for a log statement, this looks good. 👍

pypingou added a commit that referenced this pull request Mar 24, 2015
Update the GNOME backend to rely on the cache.json if present
@pypingou pypingou merged commit 665447b into master Mar 24, 2015
@pypingou pypingou deleted the gnome_cache branch March 24, 2015 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GNOME driver does not catch latest version
2 participants