Spec URL: http://ralph.fedorapeople.org//python-fedmsg-genacls.spec SRPM URL: http://ralph.fedorapeople.org//python-fedmsg-genacls-0.1-1.fc20.src.rpm Description: An example of using fedmsg to monitor pkgdb for messages, but delaying action for a few seconds to accumulate messages and avoid pile-up.
This package built on koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=6668687
Review: + Package built successfully in mock rawhide + rpmlint on generated rpms gave output python-fedmsg-genacls.noarch: W: spelling-error Summary(en_US) gitosis -> mitosis, halitosis python-fedmsg-genacls.noarch: W: spelling-error Summary(en_US) acls -> aces, ails, acts python-fedmsg-genacls.noarch: W: spelling-error Summary(en_US) pkgdb -> pkg db, pkg-db, pkg python-fedmsg-genacls.noarch: W: spelling-error %description -l en_US pkgdb -> pkg db, pkg-db, pkg python-fedmsg-genacls.src: W: spelling-error Summary(en_US) gitosis -> mitosis, halitosis python-fedmsg-genacls.src: W: spelling-error Summary(en_US) acls -> aces, ails, acts python-fedmsg-genacls.src: W: spelling-error Summary(en_US) pkgdb -> pkg db, pkg-db, pkg python-fedmsg-genacls.src: W: spelling-error %description -l en_US pkgdb -> pkg db, pkg-db, pkg 2 packages and 0 specfiles checked; 0 errors, 8 warnings. + Source verified with upstream as (sha256sum) srpm tarball:321d70af11cef939a6d665dd32accdec0e0efedf2c1b36723b038ddcf70c5ff4 upstream tarball:321d70af11cef939a6d665dd32accdec0e0efedf2c1b36723b038ddcf70c5ff4 + License is valid and included in LICENSE file + rest looks as per packaging guidelines Suggestions: 1) Either own /etc/fedmsg.d or add Requires: on package that owns that directory but I see fedmsg package should actually own it, please fix fedmsg package. 2) If this is only fedora spec then you don't need Group tag and python conditional macro definition at top of spec. Otherwise follow EPEL specific guideliens like buildroot, %clean, defattr, removal of buildroot in %install 3) cp or install commands should follow "-p" to preserve timestamp of upstream files being copied in the system.
> 1) Either own /etc/fedmsg.d or add Requires: on package that owns that directory but I see fedmsg package should actually own it, please fix fedmsg package. fedmsg fixed in rawhide now. > 2) If this is only fedora spec then you don't need Group tag and python conditional macro definition at top of spec. Otherwise follow EPEL specific guideliens like buildroot, %clean, defattr, removal of buildroot in %install Okay -- this will be for el6, but not el5. I think that means that defining the buildroot, %clean, defattr, removal of the buildroot, etc.. all are not required. > 3) cp or install commands should follow "-p" to preserve timestamp of upstream files being copied in the system. Fixed in this release: Spec URL: http://threebean.org/rpm/SPECS/python-fedmsg-genacls.spec SRPM URL: http://threebean.org/rpm/SRPMS/python-fedmsg-genacls-0.1-2.fc20.src.rpm
Looks good now. APPROVED.
New Package SCM Request ======================= Package Name: python-fedmsg-genacls Short Description: A fedmsg consumer that sets gitosis acls in response to pkgdb messages Owners: ralph janeznemanic Branches: f20 f19 el6 epel7 InitialCC:
Apologies. janeznemanic is not actually in the packagers group.
New Package SCM Request ======================= Package Name: python-fedmsg-genacls Short Description: A fedmsg consumer that sets gitosis acls in response to pkgdb messages Owners: ralph Branches: f20 f19 el6 epel7 InitialCC:
Git done (by process-git-requests).
python-fedmsg-genacls-0.1-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-fedmsg-genacls-0.1-2.fc20
python-fedmsg-genacls-0.1-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-fedmsg-genacls-0.1-2.fc19
python-fedmsg-genacls-0.1-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-fedmsg-genacls-0.1-2.el6
python-fedmsg-genacls-0.2-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-fedmsg-genacls-0.2-1.el6
python-fedmsg-genacls-0.2-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/python-fedmsg-genacls-0.2-1.fc20
python-fedmsg-genacls-0.2-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/python-fedmsg-genacls-0.2-1.fc19
python-fedmsg-genacls-0.2-1.el6 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report.
python-fedmsg-genacls-0.2-1.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report.
python-fedmsg-genacls-0.2-1.fc19 has been pushed to the Fedora 19 stable repository. If problems still persist, please make note of it in this bug report.