Allow users to specify a limit to the json leaderboard. #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With this, you could then set limit=1000000 to get a json response containing all users in the db if you wanted to, say, do analytics on Fedora Badges for a school project.
|
Could this lead to some sort of DDOS attack? |
|
Well, we were already calculating the entire leaderboard anyways (that's the compute/IO intensive part). This just returns the data we already had in memory to the user. |
|
ok 👍 then |
ralphbean
added a commit
that referenced
this pull request
Apr 24, 2015
Allow users to specify a limit to the json leaderboard.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this, you could then set limit=1000000 to get a json response
containing all users in the db if you wanted to, say, do analytics on
Fedora Badges for a school project.