Fix list ical #133
Merged
Fix list ical #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… one is specified
In iCal timezone names are most often of the type EDT or CEST or IST, but IST can be applied to the zones: ['Asia/Colombo', 'Asia/Kolkata', 'Europe/Dublin'] So we need to keep a mapping of the localized timezone name and their UTC offset to be able to track down which is which. We also define some standard timezone acronym (EDT, CET, CEST) for which we can directly substitute the name for one pytz and datetime know. This should allow us to load our own iCal files.
|
Some background information about the last three commits: http://blog.pingoured.fr/index.php?post/2014/07/25/The-Joy-of-timezones |
| in output.data) | ||
| self.assertTrue('li class="message">Calendar uploaded</li>' | ||
| in output.data) | ||
| #if 'JENKINS' not in os.environ: |
There was a problem hiding this comment.
Why run this in jenkins now? Why was it not run in jenkins before?
There was a problem hiding this comment.
Tbh, I wonder if it was failing and I am not even sure it was run at all.
I have no idea why it was there (I was surprised to see this there), I should git blame for this
There was a problem hiding this comment.
The commit that introduced the change is: 821781e the commit message is nicely helpful but looks like the problem is not occurring anymore locally
|
One question, but it looks good to me. Nice work. :D |
|
Cool, 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.