Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the unit-tests for the stackage backend #171

Merged
merged 8 commits into from Jun 23, 2015
Merged

Conversation

pypingou
Copy link
Member

@pypingou pypingou commented Jun 4, 2015

No description provided.

@dtgay
Copy link
Contributor

dtgay commented Jun 4, 2015

👍

@pypingou
Copy link
Member Author

pypingou commented Jun 4, 2015

Apparently not yet, jenkins isn't happy :)

@pypingou
Copy link
Member Author

pypingou commented Jun 4, 2015

Ok, so if @juhp could have a look at it, there is something odd with jenkins: http://jenkins.cloud.fedoraproject.org/job/anitya/

@juhp
Copy link
Contributor

juhp commented Jun 4, 2015

Hmm sorry about all that - I confess I didn't test...

http://jenkins.cloud.fedoraproject.org/job/anitya/lastUnsuccessfulBuild/consoleText

@juhp
Copy link
Contributor

juhp commented Jun 7, 2015

How can I reproduce this locally on my machine?
I followed the instructions from README.rst but don't get the above (cpphs) error.

How about merging the fix_unit-tests branch anyway? - nothing to lose I think. :)

@pypingou
Copy link
Member Author

pypingou commented Jun 8, 2015

Ok so for a reason I do not understand nor could reproduce, jenkins didn't manage to call the stackage server.
Thanks to @ralphbean we're now using the VCR library that allows caching the requested page, so I've added these cache files and now jenkins is happy.

My only wonder is if the files tests/tests/request-data/__main__.* are needed :)

@ralphbean
Copy link
Contributor

My only wonder is if the files tests/tests/request-data/main.* are needed :)

That may depend on how the tests were run? I.e. if you run the file directly versus using nosetests, I bet the name of the module is different (i.e., it gets __main__ prefixed).

@ralphbean
Copy link
Contributor

Easy way to tell: delete them and re-run the tests with runtests.sh. If they don't come back, then they're not needed.

@pypingou
Copy link
Member Author

So indeed it's not needed :), removed!

So I guess it's ready to be merged, a final +1 anyone?

@ralphbean
Copy link
Contributor

💯

pypingou added a commit that referenced this pull request Jun 23, 2015
Fix the unit-tests for the stackage backend
@pypingou pypingou merged commit 433dd1e into master Jun 23, 2015
@pypingou pypingou deleted the fix_unit-tests branch June 23, 2015 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants