Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add less detailed git commit filter #55

Closed
nirik opened this issue Feb 21, 2015 · 9 comments
Closed

Add less detailed git commit filter #55

nirik opened this issue Feb 21, 2015 · 9 comments

Comments

@nirik
Copy link
Member

nirik commented Feb 21, 2015

The current dist git comment includes a diff. It might be nice to have a filter that just gives a link to the commit without the diff.

@robert-scheck
Copy link

It also would be a better default if not both (git and fmn) are sending a notification by default. So if you just enable e-mail communication, you receive two e-mails for each commit or merge.

@ralphbean
Copy link

@pypingou, @bochecha - can we turn off email from gitolite3 before freeze sets in on Tuesday? Or is that too rushed.

@ralphbean
Copy link

To disable dist-git emails we need to make sure and add a scm-commits FAS user who gets them still for the scm-commits list

Messages for commits, pkgdb changes, and lookaside uploads.

https://lists.fedoraproject.org/pipermail/scm-commits/Week-of-Mon-20150216/thread.html

@robert-scheck
Copy link

FMN also sends always the full diff (after e.g. git merge origin/master) even if the Git e-mail just tells that the diff has been already sent in a separate e-mail.

@pypingou
Copy link
Member

I think it's a git hook sending the email, so it should be fairly simple to drop it

@bochecha
Copy link

Yeah, it's the gnome-post-receive-send-email commit hook (not sure the exact name, but it's definitely 'post-receive' and it's based on the original GNOME one)

@ralphbean
Copy link

So, we need a way for the git hook that sends fedmsg messages originally to detect if the commit already exists in another branch, and if so.. just mark that somehow in the message.

Later, when the message is received, we can look for that flag in the message and only return a small amount of text in the long_form routine.

@ralphbean
Copy link

we need a way for the git hook that sends fedmsg messages originally to detect if the commit already exists in another branch, and if so.. just mark that somehow in the message.

This is done now with the seen field in the git.receive messages now.

we can look for that flag in the message and only return a small amount of text in the long_form routine.

This is done now (and deployed) as of fedora-infra/fedmsg_meta_fedora_infrastructure#233

@ralphbean
Copy link

OK, old email mechanisms are now turned off. FMN is sending pkgdb, git, and lookaside messages to the scm-commits list.

jeremycline pushed a commit to jeremycline/fmn that referenced this issue Dec 7, 2016
Only append the "triggered by" link to emails if the user wants it.
jeremycline pushed a commit to jeremycline/fmn that referenced this issue Dec 7, 2016
jeremycline pushed a commit to jeremycline/fmn that referenced this issue Dec 7, 2016
jeremycline pushed a commit that referenced this issue Apr 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants