Spec URL: http://ralph.fedorapeople.org//nodejs-portscanner.spec SRPM URL: http://ralph.fedorapeople.org//nodejs-portscanner-1.0.0-1.fc20.src.rpm Description: The portscanner module is an asynchronous JavaScript port scanner for Node.js.
Review: + mock build is successful for f22 - rpmlint output on rpms gave nodejs-portscanner.src: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-portscanner.src: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-portscanner.x86_64: W: spelling-error Summary(en_US) js -> dis, ks, j nodejs-portscanner.x86_64: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-portscanner.x86_64: E: no-binary nodejs-portscanner.x86_64: W: only-non-binary-in-usr-lib nodejs-portscanner.x86_64: W: dangling-symlink /usr/lib/node_modules/portscanner/node_modules/async /usr/lib/node_modules/async nodejs-portscanner-debuginfo.x86_64: E: empty-debuginfo-package 3 packages and 0 specfiles checked; 2 errors, 6 warnings. ==> See suggestion below + Source verified with upstream as (sha256sum) srpm tarball :20195e1ab19d851ebe3d595218b376a1e4486035d627d0262fe0d4ba3fa8e1f5 upstream tarball :20195e1ab19d851ebe3d595218b376a1e4486035d627d0262fe0d4ba3fa8e1f5 + License "MIT" is valid and is included in its own file as %doc. + rest looks following packaging guidelines Suggestions: 1) Add following to spec BuildArch: noarch %if 0%{?fedora} >= 19 ExclusiveArch: %{nodejs_arches} noarch %else ExclusiveArch: %{ix86} x86_64 %{arm} noarch %endif
New release your address your suggestion: Spec URL: http://threebean.org/rpm/SPECS/nodejs-portscanner.spec SRPM URL: http://threebean.org/rpm/SRPMS/nodejs-portscanner-1.0.0-2.fc20.src.rpm
Thanks for the update. New srpm looks good. APPROVED.
New Package SCM Request ======================= Package Name: nodejs-portscanner Short Description: Asynchronous port scanner for Node.js Upstream URL: https://npmjs.org/package/portscanner Owners: ralph Branches: f21,f20,f19,epel7,el6 InitialCC:
Git done (by process-git-requests).
nodejs-portscanner-1.0.0-2.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-portscanner-1.0.0-2.fc20
nodejs-portscanner-1.0.0-2.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-portscanner-1.0.0-2.fc19
Buildroot overrides have been created.
nodejs-portscanner-1.0.0-2.fc20 has been pushed to the Fedora 20 stable repository.
nodejs-portscanner-1.0.0-2.fc19 has been pushed to the Fedora 19 stable repository.