Create and attach patches to bz tickets we file. #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.. instead of emailing sysadmin-datanommer. Almost always, this is an error in the specfile and I'd like to make the packager(s) aware of that since I can't really do anything about it myself.
|
|
||
| # Copy the patch out of this doomed dir so bz can find it | ||
| destination = '/var/tmp/' + filename | ||
| shutil.move('/'.join([tmp, filename]), destination) |
There was a problem hiding this comment.
This line scares me a little as it would accept a folder as well as a file, bu on the other side things are pretty contained about what they can do.
Btw, '/'.join() not os.path.join()?
|
One question, otherwise 👍 |
ralphbean
added a commit
that referenced
this pull request
Mar 26, 2015
Create and attach patches to bz tickets we file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also, propagate srpm-creation and koji-kickoff errors to the ticket, instead of
emailing sysadmin-datanommer.
Almost always, this is an error in the specfile and I'd like to make the
packager(s) aware of that since I can't really do anything about it myself.