Feature/alert new post #6
Conversation
|
Maybe we should remove all the commented console.log directly, I'm not sure there is much interest in keeping them in. |
| @@ -182,5 +182,39 @@ function setup_websocket_listener() { | |||
| // the websocket connection, but we have to go query again to | |||
| // get the fedmsg.meta information. | |||
| update_fedmsg(id_lookup[category], category, deploy); | |||
|
|
|||
| // Add blink effect on page's title to alert user of new post | |||
| // Note: this code is adapted from canop's blog (canop.org) | |||
There was a problem hiding this comment.
Might be worth putting the whole url.
Is there a license on the code there?
There was a problem hiding this comment.
In fact, canop re-writes in his "words" what it is explained on page : https://developer.mozilla.org/en-US/docs/Web/Guide/User_experience/Using_the_Page_Visibility_API?redirectlocale=en-US&redirectslug=DOM%2FUsing_the_Page_Visibility_API which license is "Creative Commons Attribution-ShareAlike".
There was a problem hiding this comment.
It's actually public license:
Code samples added on or after August 20, 2010 are in the public domain. No licensing notice is necessary, but if you need one, you can use: "Any copyright is dedicated to the Public Domain. http://creativecommons.org/publicdomain/zero/1.0/".
So from a license point of view, it's ok to merge it, just add the full link please.
| } else { | ||
| blinkTimer = setInterval(function() { | ||
| var title = document.title; | ||
| document.title = (title === originalTitle) ? "New " + id_lookup[category] : originalTitle; |
There was a problem hiding this comment.
What about moving the test up a little so that we do no update the document.title unless there is a change?
There was a problem hiding this comment.
This effect is applied at each received message (from all categories). Perhaps we can apply this effect only when we receive messages which its categroy is 'planet'.
There was a problem hiding this comment.
I think it's worth keeping it for all pages
|
I have this running for a while now and it works good, so let's merge it :) |
Add blink effect when new message is received