Feature/pkgdb2 and fas updates #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| except AppError: | ||
| irc.reply("No such package exists.") | ||
| return | ||
| branch_list = [] | ||
| for listing in pkginfo['packageListings']: | ||
| for listing in pkkinfo['packages']: |
Closed
|
Thanks for the ping. Typo fixed. |
| @@ -46,7 +46,7 @@ | |||
| from fedora.client import ServerError | |||
| from fedora.client.fas2 import AccountSystem | |||
| from fedora.client.fas2 import FASError | |||
| from fedora.client.pkgdb import PackageDB | |||
| from pkgdb2client import PkgDB | |||
There was a problem hiding this comment.
Should we explicitly require packagedb-cli somewhere?
|
one question, otherwise 👍 for me |
|
Done. There's no setup.py or spec file but I added it to the requirements.txt |
|
Looks all good to me 😄 👍 |
|
@abadger should we merge this? |
|
👍 from me. |
pypingou
added a commit
that referenced
this pull request
Aug 18, 2014
Feature/pkgdb2 and fas updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FAS and Pkgdb updated last week. This set of changes updates the use of pkgdb to the pkgdb2 api. The FAS update made the query we use slower. This update also increases the client-side timeout that supybot uses so that it can complete the request.