More information for the custom backend #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This link provides more information on how to test your regex
| @@ -82,6 +82,7 @@ def test_add_distro(self): | |||
| sess['email'] = 'pingou@pingoured.fr' | |||
|
|
|||
| output = c.get('/distro/add', follow_redirects=True) | |||
| print output.data | |||
There was a problem hiding this comment.
Is this something left over from testing, or should this now always be in the tests?
There was a problem hiding this comment.
Left over from testing indeed, but not a problem when ran with runtests.sh (cuts stdout unless the test breaks)
| $('#example_txt').append( | ||
| '<br /> More information in the ' | ||
| + '<a href="{{ url_for("about") }}#test-you-regex">' | ||
| + 'about#test-you-regex</a>' |
There was a problem hiding this comment.
Maybe also make this use url_for?
There was a problem hiding this comment.
I thought you previously displayed the full URL. Never mind the comment.
There was a problem hiding this comment.
I did, but url_for will not show the full url, it will just give /about, which I thought was even worse than just about#...
…ive more information
This will make the page lighter and thus easier to load but also easier to read when looking at the sources
|
👍 |
|
Thanks ! |
pypingou
added a commit
that referenced
this pull request
Feb 24, 2015
More information for the custom backend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #71