Spec URL: http://ralph.fedorapeople.org//nodejs-gonzales-pe.spec SRPM URL: http://ralph.fedorapeople.org//nodejs-gonzales-pe-3.0.0-0.1.6.fc20.src.rpm Description: Gonzales is a fast CSS parser. Gonzales PE is a rework with support of preprocessors.
fedora-review reported new srpm available at your people page. If there is any update available, can you please add it here?
Sorry for the confusion, Parag. The update contained the latest upstream release as well as a reduction in the amount of use of 'nodejs_fixdep' statements. Spec URL: http://ralph.fedorapeople.org//nodejs-gonzales-pe.spec SRPM URL: http://ralph.fedorapeople.org//nodejs-gonzales-pe-3.0.0-0.1.9.fc20.src.rpm
Review: + mock build is successful for f22 - rpmlint output on rpms gave nodejs-gonzales-pe.src: W: spelling-error %description -l en_US preprocessors -> processors, predecessors, microprocessor nodejs-gonzales-pe.x86_64: W: spelling-error %description -l en_US preprocessors -> processors, predecessors, microprocessor nodejs-gonzales-pe.x86_64: E: no-binary nodejs-gonzales-pe.x86_64: W: only-non-binary-in-usr-lib nodejs-gonzales-pe-debuginfo.x86_64: E: empty-debuginfo-package 3 packages and 0 specfiles checked; 2 errors, 3 warnings. ==> See below suggestions + Source verified with upstream as (sha256sum) srpm tarball :4b6bd26612b5dd221696f9a638ed6a8af950c98664400fe3e41b6c040928cf47 upstream tarball :4b6bd26612b5dd221696f9a638ed6a8af950c98664400fe3e41b6c040928cf47 + License "MIT" is valid - License file is not packaged. + rest looks following packaging guidelines Suggestions: 1) Add following to spec BuildArch: noarch %if 0%{?fedora} >= 19 ExclusiveArch: %{nodejs_arches} noarch %else ExclusiveArch: %{ix86} x86_64 %{arm} noarch %endif 2) Add doc directory files and MIT-LICENSE.txt as %doc Please provide updated package
New release should address your suggestions: Spec URL: http://threebean.org/rpm/SPECS/nodejs-gonzales-pe.spec SRPM URL: http://threebean.org/rpm/SRPMS/nodejs-gonzales-pe-3.0.0-0.2.9.fc20.src.rpm
Thanks for the update. New srpm looks good. APPROVED.
New Package SCM Request ======================= Package Name: nodejs-gonzales-pe Short Description: Gonzales Preprocessor Edition (fast CSS parser) Upstream URL: https://npmjs.org/package/gonzales-pe Owners: ralph Branches: f21,f20,f19,epel7,el6 InitialCC:
Git done (by process-git-requests).
nodejs-gonzales-pe-3.0.0-0.2.9.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-gonzales-pe-3.0.0-0.2.9.fc20
nodejs-gonzales-pe-3.0.0-0.2.9.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-gonzales-pe-3.0.0-0.2.9.fc19
Buildroot overrides have been created.
nodejs-gonzales-pe-3.0.0-0.2.9.fc20 has been pushed to the Fedora 20 stable repository.
nodejs-gonzales-pe-3.0.0-0.2.9.fc19 has been pushed to the Fedora 19 stable repository.