Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

making 2 links on a line distinguishable #64

Closed

Conversation

ShaguftaMethwani
Copy link
Contributor

No description provided.

@pypingou
Copy link
Member

While technically correct I have a few issues with this change:

a) you are using upper tags which is HTML4
b) you rely on <pre> to give more space between the two elements while this should be handled by CSS
c) there is probably a much easier solution for this, I don't think adding space(s) between the two links is the best one, people could still think it is one link.

@ShaguftaMethwani
Copy link
Contributor Author

Giving a space separates them and the dashes will point out to the stats so it won't look like a single link, but pointing out to the stats. Also, since the dashes aren't underlined(no hyperlink) so the confusion will not be there. The problem currently is that there is only a single hyphen which is so small that it isn't clear if it is blue or black or underlined or not. That's why I took the simple approach of adding more number of hyphens. I should remove the PRE though, I agree

@ShaguftaMethwani
Copy link
Contributor Author

@pypingou Is this fine? #66

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants