This repository has been archived by the owner on Jan 14, 2021. It is now read-only.
Fix 'undefined' when clicking monitor toggle. #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While I'm ok with the fix, I cannot reproduce the case described here. When I'm not logged in, clicking on |
|
@pypingou Updated based on IRC discussion. +1s? |
|
Maybe be a little more generous/rigorous in our check? https://github.com/fedora-infra/pkgdb2/blob/fix-undefined/pkgdb2/templates/package.html#L40-L42 |
When you click the monitoring toggle and you are not logged in, it makes the request anyway and then appends "undefined" to the page. This looks tacky. Instead don't define the click handler unless the user is logged in. Signed-off-by: Ricky Elrod <ricky@elrod.me>
|
@pypingou boom! |
|
👍 thanks @relrod ! |
relrod
added a commit
that referenced
this pull request
Mar 26, 2015
Fix 'undefined' when clicking monitor toggle.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you click the monitoring toggle and you are not logged in, it makes
the request anyway and then appends "undefined" to the page. This looks
tacky. Instead, if we don't get a response back, just bail out and do
nothing.
Signed-off-by: Ricky Elrod ricky@elrod.me