Avoid recursively walking the entire git history. #323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will run us into the limit for recursive calls as jwb just pointed out in ``#fedora-admin``.
| @@ -97,7 +81,7 @@ for line in lines: | |||
|
|
|||
| try: | |||
| base = repo.revparse_single(base) | |||
| ancestors = list(gather_ancestors(base)) | |||
| ancestors = [commit.id for commit in repo.walk(base.id)] | |||
There was a problem hiding this comment.
Should we pass it sorting info?
There was a problem hiding this comment.
I take it back. The list of ancestors can be in any order. We're only checking for membership in it to figure out when to stop second part of the hook later on.
|
One question, otherwise 👍 |
ralphbean
added a commit
that referenced
this pull request
Feb 23, 2015
Avoid recursively walking the entire git history.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will run us into the limit for recursive calls as jwb just pointed out
in
#fedora-admin.