prevent IndexError when examining tasks that don't have raw.xz outputs #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| elif len(builds) >= 2: | ||
| koji_session.multicall = True | ||
| for build in builds: | ||
| koji_session.getTaskResult(build) | ||
| results = koji_session.multiCall() | ||
| for result in results: | ||
| rawxz_files.append(get_rawxz_url(result[0])) | ||
| url = get_rawxz_url(result[0]) |
There was a problem hiding this comment.
Couldn't this be the IndexError, if result is empty?
There was a problem hiding this comment.
Yeah, but it's not the IndexError we've been seing in the logs. Nonetheless, it would be good to check if result first.
There was a problem hiding this comment.
Thanks for the review. Fixed this. Good to merge?
|
👍 for me |
dtgay
pushed a commit
that referenced
this pull request
Apr 20, 2015
prevent IndexError when examining tasks that don't have raw.xz outputs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a big "do'h" moment just now and realized this will fix the IndexError error messages we've been seeing on fedimg machines. This should fix #23.