This repository has been archived by the owner on Jan 14, 2021. It is now read-only.
Optimize packager acls #111
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and PackageListing
This is due to the change in PackageListingAcl.get_acl_packager that returns now the ACL as well as the PackageListing object.
|
Awesome work :) Does this change the format of response returned by the JSON api at all? |
According to my tests and my unit-tests nope, but for sure we should be extra-careful in testing this :) |
|
Cool -- 👍 :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By returning more info directly from the DB rather than loading it when building the JSON, the api endpoint /api/packager/acl// went from 10+seconds to 0.3 seconds.