Generate the update ID/alias upon creation #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can cause weird createrepo_c exceptions to get thrown in places that you wouldn't expect.
| @@ -1147,7 +1147,7 @@ def test_edit_update(self, publish, *args): | |||
| self.assertEquals(up['date_approved'], None) | |||
| self.assertEquals(up['date_pushed'], None) | |||
| self.assertEquals(up['locked'], False) | |||
| self.assertEquals(up['alias'], None) | |||
| self.assertEquals(up['alias'], u'FEDORA-2015-0002') | |||
There was a problem hiding this comment.
Do you want to use time.localtime here for the year? I.e., will these tests break when we get to 2016?
There was a problem hiding this comment.
Or, use freezegun.freeze_time('2015-06-03') on the test.
|
Looks good all-in-all. 👍 |
|
Thanks for the review! |
lmacken
added a commit
that referenced
this pull request
May 20, 2015
Generate the update ID/alias upon creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As opposed to when it's initially pushed to testing, which is how it is currently done.