Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

De-duplicate subtitles from long_form representations. #237

Merged
merged 1 commit into from Mar 24, 2015

Conversation

ralphbean
Copy link
Contributor

Before this, we would include the 'subtitle' as a part of every long_form
representation and it just seems kind of silly now. It means that, for emails
there would be the Subject with the subtitle, then the contents of the email
would contain the subtitle again followed by the long_form. This gets rid of
that duplicate in there.

We'll have to make one other change to fmn.consumer to tell it to do
included the subtitle if the messages show up in a batch email, since the
'Subject' won't be there to clarify.

Before this, we would include the 'subtitle' as a part of every long_form
representation and it just seems kind of silly now.  It means that, for emails
there would be the Subject with the subtitle, then the contents of the email
would contain the subtitle *again* followed by the long_form.  This gets rid of
that duplicate in there.

We'll have to make one other change to fmn.consumer to tell it to **do**
included the subtitle if the messages show up in a batch email, since the
'Subject' won't be there to clarify.
@pypingou
Copy link
Member

👍 for me, let's see what travis says :-)

ralphbean added a commit to fedora-infra/fmn.consumer that referenced this pull request Mar 24, 2015
ralphbean added a commit that referenced this pull request Mar 24, 2015
De-duplicate subtitles from long_form representations.
@ralphbean ralphbean merged commit e7bf101 into develop Mar 24, 2015
@ralphbean ralphbean deleted the feature/de-duplicate-subtitle branch March 24, 2015 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants