Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double hidden files are evil #103

Closed
mcepl opened this issue Sep 15, 2014 · 7 comments
Closed

Double hidden files are evil #103

mcepl opened this issue Sep 15, 2014 · 7 comments
Labels

Comments

@mcepl
Copy link

mcepl commented Sep 15, 2014

I mean specifically ~/.fedora/.fedora_session. When I enter a hidden directory I don't expect (and you don't need to) another secrets hidden from me. Make the .fedora_session file unhidden please.

@abdelgmartinezl
Copy link
Contributor

Please review the pull-request #109.

Thanks in advance.

@mcepl
Copy link
Author

mcepl commented Nov 7, 2014

It serves the quality of the source code, if python-fedora is really so DRY as it seems to be. I don't have much more to say. Now the developers should have their word.

Technically I would just mention https://help.github.com/articles/closing-issues-via-commit-messages/ one line in the commit message ("Fixes #103") would simplify the situation a lot.

@pypingou
Copy link
Member

pypingou commented Nov 7, 2014

so dry ?

@mcepl
Copy link
Author

mcepl commented Nov 7, 2014

so dry ?

It was meant as a compliment ... one line change is enough (as it should be).

@pypingou
Copy link
Member

pypingou commented Nov 7, 2014

ah cool :)
Sorry I was confused, first time I heard the adjective dry applied to a piece of code :)

@mcepl
Copy link
Author

mcepl commented Nov 7, 2014

See https://en.wikipedia.org/wiki/Don%27t_repeat_yourself (and http://c2.com/cgi/wiki?DontRepeatYourself)

And it is DRY (as an abbreviation), not dry (as not wet).

@ralphbean
Copy link
Contributor

Closed by #109. Thanks @ampotty!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants