Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable rather than delete filters #13

Closed
kparal opened this issue Feb 11, 2014 · 5 comments
Closed

disable rather than delete filters #13

kparal opened this issue Feb 11, 2014 · 5 comments

Comments

@kparal
Copy link

kparal commented Feb 11, 2014

As a newcomer, I'm not sure I want to delete some of the pre-defined filters, but I'd like to disable some of them and delete them if I find out I'm not missing anything. Please allow to disable filters, it's much more user friendly than outright deleting them.
@ralphbean
Copy link

This requires that we first add a database column to fmn.lib indicating that a filter is disabled or not.

We need:

  • to add that column in fmn.lib
  • to add an alembic upgrade script in fmn.lib to add that column
  • load_preferences in fmn.lib should make use of the new column and not return the filter if it is disabled
  • the UI in fmn.web needs a button and stuff to turn this on and off

pypingou added a commit to fedora-infra/fmn.lib that referenced this issue Sep 3, 2014
@pypingou
Add an active field to the filters table allowing to disable a filt…
94bbbd0 
…er w/o deleting it

Relates to fedora-infra/fmn#13
pypingou added a commit to fedora-infra/fmn.lib that referenced this issue Sep 3, 2014
@pypingou
Add an alembic migration script adding the active field to the filt…
5059c87 
…ers table

Relates to fedora-infra/fmn#13
pypingou added a commit to fedora-infra/fmn.lib that referenced this issue Sep 3, 2014
@pypingou
Only include the filters that are active in the json representation o…
913c131 
…f the preferences

Relates to fedora-infra/fmn#13
@pypingou
Copy link
Member

pypingou commented Sep 3, 2014

These three commits should address the first two items and maybe the third one (to be confirmed by @ralphbean )

@rossdylan
Copy link

I'm currently working on the bits in fmn.web to enable/disable filters. Patch should up today

@ralphbean
Copy link

@pypingou can you submit a pull request to discuss the code? I left a comment in fedora-infra/fmn.lib@5059c87

@ralphbean
Copy link

Closed by fedora-infra/fmn.lib#15 and fedora-infra/fmn.web#31

jeremycline pushed a commit to jeremycline/fmn that referenced this issue Dec 7, 2016
@ralphbean
Merge pull request fedora-infra#13 from fedora-infra/feature/short-ba…
27b1cfb 
…cklinks

Provide shortlinks back to filters that trigger messages.
jeremycline pushed a commit to jeremycline/fmn that referenced this issue Dec 7, 2016
@ralphbean
Merge pull request fedora-infra#13 from fedora-infra/feature/whats-ol…
9e6b00e 
…d-is-new-again

Switch back to using user-centric caching.
jeremycline pushed a commit to jeremycline/fmn that referenced this issue Dec 7, 2016
@pypingou
Merge pull request fedora-infra#13 from rossdylan/disable_filter
086a63c 
Added a method on the Preference model to disable/enable filters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ralphbean @rossdylan @kparal @pypingou