Conversation
@abompard my other commits also got added up to this requests. I am removing other commits from this request. |
@abompard done 👍 |
I was seeing this pull-request after seeing: https://github.com/fedora-infra/fresque/pull/2/files#diff-04c6e90faac2675aa89e2176d2eec7d8R66 Does it make much sense then? |
@pypingou this pull request is different. I have .travis.yml file for build process reporting. Should I remove this for now? |
This looks fine and simple to me. |
Is their any change I need to make on this? |
I was just wondering, since fresque depends on pygit2 which itself depends on libgit2 which is a pure C(++) library which cannot be installed by pip, will travis work? Even to just check if it compiles, I would expect it will need all the dependencies installed so would it work? |
It can still be installed inside a virtualenv, so you can do that in Travis. |
add .travis.sh for libgit2 setup
@pypingou updated to support libgit2. |
@rahulrrixe seems to be missing the piece about |
@pypingou couldn't got your last comment :(. |
See the link from bochecha |
@pypingou he's just doing it a different way. It looks fine to me. |
@ralphbean ah, I think I see now with the env variable iiuc |
OK - I'm merging this and turning on the travis webhook. Thanks so much @rahulrrixe! |
@abompard I have added this for basic automatic build reporting.