Skip to content
This repository has been archived by the owner on Jul 24, 2018. It is now read-only.

Add .travis.yml #3

Merged
merged 1 commit into from May 14, 2015
Merged

Add .travis.yml #3

merged 1 commit into from May 14, 2015

Conversation

fluffybeing
Copy link
Contributor

@abompard I have added this for basic automatic build reporting.

@fluffybeing fluffybeing deleted the travis branch March 16, 2015 04:00
@fluffybeing fluffybeing restored the travis branch March 16, 2015 04:04
@fluffybeing
Copy link
Contributor Author

@abompard my other commits also got added up to this requests. I am removing other commits from this request.

@fluffybeing
Copy link
Contributor Author

@abompard done 👍

@pypingou
Copy link
Member

I was seeing this pull-request after seeing: https://github.com/fedora-infra/fresque/pull/2/files#diff-04c6e90faac2675aa89e2176d2eec7d8R66

Does it make much sense then?

@fluffybeing
Copy link
Contributor Author

@pypingou this pull request is different. I have .travis.yml file for build process reporting. Should I remove this for now?

@ralphbean
Copy link
Contributor

This looks fine and simple to me.

@fluffybeing
Copy link
Contributor Author

Is their any change I need to make on this?

@pypingou
Copy link
Member

I was just wondering, since fresque depends on pygit2 which itself depends on libgit2 which is a pure C(++) library which cannot be installed by pip, will travis work? Even to just check if it compiles, I would expect it will need all the dependencies installed so would it work?

@bochecha
Copy link

which cannot be installed by pip

It can still be installed inside a virtualenv, so you can do that in Travis.

add .travis.sh for libgit2 setup
@fluffybeing
Copy link
Contributor Author

@pypingou updated to support libgit2.

@pypingou
Copy link
Member

@rahulrrixe seems to be missing the piece about LIBGIT2

@fluffybeing
Copy link
Contributor Author

@pypingou couldn't got your last comment :(.

@pypingou
Copy link
Member

See the link from bochecha

@ralphbean
Copy link
Contributor

@pypingou he's just doing it a different way. It looks fine to me.

@pypingou
Copy link
Member

pypingou commented May 7, 2015

@ralphbean ah, I think I see now with the env variable iiuc

@ralphbean
Copy link
Contributor

OK - I'm merging this and turning on the travis webhook. Thanks so much @rahulrrixe!

ralphbean added a commit that referenced this pull request May 14, 2015
@ralphbean ralphbean merged commit 8227a52 into fedora-infra:master May 14, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants