Navigation Menu

Skip to content
This repository has been archived by the owner on Jan 14, 2021. It is now read-only.

Approve commit access once per user #84

Closed
voxik opened this issue Aug 28, 2014 · 9 comments · Fixed by #89
Closed

Approve commit access once per user #84

voxik opened this issue Aug 28, 2014 · 9 comments · Fixed by #89

Comments

@voxik
Copy link
Contributor

voxik commented Aug 28, 2014

When somebody asks me for permissions of all Fedora/EPEL branches, I have to go through every branch column in Edit Commit Access page [1] and set it explicitly on approved. Is there chance to approve them in once?

It might be some additional column? May be it could be just some client side JS, which would update combo states in every branch column? When I have no right to approve right for some branch, the setting will fail just for that specific branch (actually this works already, so it should not be any issue).

[1] https://admin.fedoraproject.org/pkgdb/package/rubygem-rack/acl/commit/

@pypingou
Copy link
Member

https://admin.fedoraproject.org/pkgdb/acl/pending/ has a button to approve/deny all pending requests already :)

@voxik
Copy link
Contributor Author

voxik commented Aug 28, 2014

Isn't it too big hammer?

@voxik
Copy link
Contributor Author

voxik commented Aug 28, 2014

Moreover, once you accept the ACLs, you can't deny them using this button

@pypingou
Copy link
Member

On Thu, 2014-08-28 at 11:49 -0700, Vít Ondruch wrote:

Moreover, once you accept the ACLs, you can't deny them using this button

This sentence confuses me :)

@voxik
Copy link
Contributor Author

voxik commented Aug 28, 2014

Well, the pending acls page can be used just if somebody asks you for confirmation. But if you decide for whatever reason, that you want to deny already assigned rights, it is useless.

@pypingou
Copy link
Member

On Thu, Aug 28, 2014 at 12:17:42PM -0700, Vít Ondruch wrote:

Well, the pending acls page can be used just if somebody asks you for
confirmation. But if you decide for whatever reason, that you want to deny
already assigned rights, it is useless.

I agree but it sounds quite logical to me, if the ACLs are assigned, they are
not pending :)

@voxik
Copy link
Contributor Author

voxik commented Aug 28, 2014

Yes, I don't dispute that :) The only thing I wanted to say is that it does not fit exactly my RFE

@juhp
Copy link

juhp commented Oct 8, 2015

I would prefer if this could be implemented as a bit of UI: something like an [Approve requested] button.
One doesn't always want to approve all branches (even unrequested ones;) in one go. :)

cf https://fedorahosted.org/pkgdb2/ticket/46

@pypingou
Copy link
Member

pypingou commented Oct 8, 2015

The current behavior is more than [Approve All] it can also be [Deny All], you could use it to make everything Denied but the one you're interested in granted or vice-versa

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants