Skip to content
This repository has been archived by the owner on Jul 24, 2018. It is now read-only.

Well, at first I made some changes in the front-end design (color change, adding up the fedora logo, change the position of the source link, white background tabs with collapse). How about adding a new link to the fedora badges? #8

Closed
wants to merge 4 commits into from

Conversation

scovl
Copy link

@scovl scovl commented Jun 28, 2014

No description provided.

@pypingou
Copy link
Member

Could you maybe provide a little more information as to what each commit is doing? The commit message are rather unclear.

@scovl
Copy link
Author

scovl commented Jun 30, 2014

Alright. I don't informed because the github somehow already tells you what
the changes were. But ok, I'll send commits with better comments.

2014-06-29 5:15 GMT-03:00 Pierre-Yves Chibon notifications@github.com:

Could you maybe provide a little more information as to what each commit
is doing? The commit message are rather unclear.


Reply to this email directly or view it on GitHub
#8 (comment)
.

@pypingou
Copy link
Member

Github is a plateform on the top of git, the tool that matters is git, not github.

In addition, if even git can show you the changes but it does not provide any explanation as to why these changes were made.

@scovl
Copy link
Author

scovl commented Jun 30, 2014

Ok, sorry :)

2014-06-30 9:48 GMT-03:00 Pierre-Yves Chibon notifications@github.com:

Github is a plateform on the top of git, the tool that matters is git, not
github.

In addition, if even git can show you the changes but it does not provide
any explanation as to why these changes were made.


Reply to this email directly or view it on GitHub
#8 (comment)
.

@pypingou
Copy link
Member

No problem ;-)

And it's always nice to see new people interesting in this small application :)

@scovl scovl changed the title small changes Well, at first I made some changes in the front-end design (color change, adding up the fedora logo, change the position of the source link, white background tabs with collapse). How about adding a new link to the fedora badges? Jun 30, 2014
@scovl
Copy link
Author

scovl commented Jun 30, 2014

Well, at first I made some changes in the front-end design (color change,
adding up the fedora logo, change the position of the source link, white
background tabs with collapse). How about adding a new link to the fedora
badges?

2014-06-30 10:22 GMT-03:00 Pierre-Yves Chibon notifications@github.com:

No problem ;-)

And it's always nice to see new people interesting in this small
application :)


Reply to this email directly or view it on GitHub
#8 (comment)
.

@scovl
Copy link
Author

scovl commented Jun 30, 2014

This small application will be very useful for ambassadors fedora and
members of the team in general. Or even to implement the feature on news
portals (there is a proposal to re opening fedora magazine in Brazil for
example).

2014-06-30 10:23 GMT-03:00 Vitor Lobo lobocode@gmail.com:

Well, at first I made some changes in the front-end design (color change,
adding up the fedora logo, change the position of the source link, white
background tabs with collapse). How about adding a new link to the fedora
badges?

2014-06-30 10:22 GMT-03:00 Pierre-Yves Chibon notifications@github.com:

No problem ;-)

And it's always nice to see new people interesting in this small
application :)


Reply to this email directly or view it on GitHub
#8 (comment)
.

@pypingou
Copy link
Member

pypingou commented Jul 2, 2014

I fear I have probably not be clear, I was speaking about improving the commit messages so that the information is and remains present for all

Fedora image icon 32x32 in navbar
@pypingou
Copy link
Member

ping? Need some help to fix the commit messages?

@pypingou
Copy link
Member

pypingou commented Aug 5, 2014

ping ?

@scovl
Copy link
Author

scovl commented Aug 7, 2014

At home, I'm revamping the entire front-end of fedora news using bootstrap metroui and separating html modules each link (easier to support in this way). Soon I will show this experiment :)

@pypingou
Copy link
Member

pypingou commented Aug 7, 2014

How does bootstrap metroui behaves on mobiles?

@scovl
Copy link
Author

scovl commented Aug 7, 2014

Very well.Is responsive and ideal for this project.

@pypingou
Copy link
Member

I'm going to close this for now.

Please open a new pull-request when you have your work ready and please be careful with the commit messages :)

Thanks for your work!

@pypingou pypingou closed this Sep 26, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants