Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFE: strip common github tag prefixes #102

Closed
scop opened this issue Feb 24, 2015 · 3 comments
Closed

RFE: strip common github tag prefixes #102

scop opened this issue Feb 24, 2015 · 3 comments

Comments

@scop
Copy link

scop commented Feb 24, 2015

It'd be good to strip common prefixes used in github tags that are not part of the version string. At least a leading "v" could be removed, ditto "$project-".
@pypingou
Copy link
Member

The v prefix does not matter in ordering the releases and tbh, I'd rather have the consumer of anitya teach the upstream project how to properly tag/version their projects :)

@scop
Copy link
Author

scop commented Feb 24, 2015

The v etc prefixes start to matter if/when those versions are compared against versions of packages let's say in rawhide. I suppose anitya does that - or is it the-new-hotness? There's nothing wrong with the mentioned tag prefixes so the time spent trying to teach this to someone would be more productive somewhere else.

@pypingou
Copy link
Member

The-new-hotness is the one comparing the version with what is in Fedora.

ralphbean added a commit to fedora-infra/the-new-hotness that referenced this issue Feb 26, 2015
@ralphbean
Strip leading v.
4f10bae 
Which is sometimes prefixed on github version tags.

Fixes fedora-infra/anitya#102
@ralphbean ralphbean mentioned this issue Feb 26, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scop @pypingou