Add ULS language selector & create global static folder #20
Conversation
| @@ -45,16 +48,7 @@ <h3 class="masthead-brand">${title}</h3> | |||
| % endfor | |||
|
|
|||
| <li class="dropdown"> | |||
There was a problem hiding this comment.
This whole dropdown entry can probably be removed from the top navbar now that the uls language selector is in the footer, no?
There was a problem hiding this comment.
Oops. You're right
|
Does the freeze affect this? |
I don't think so. It (1) isn't hosted in infra and (2) doesn't play a role in preparing the alpha release, so I think we're free to make changes. |
|
Yeah, no freeze concerns here... should be able to make whatever changes you need. ;) |
|
@ralphbean I took away the unneeded dropdown. What do you think? |
|
@cydrobolt I had to make only one little change in 10938ef, but it looks good. Thanks for this! It's live up on http://whatcanidoforfedora.org now 🚀 |
Add ULS language selector & create global static folder
|
On http://whatcanidoforfedora.org, the global static files aren't in the correct place. Works locally, though. Maybe something with OpenShift? @ralphbean |
Really?
Did you try doing a hard-reload of the page? |
|
Yes, tried hard-reload. I know the global static files aren't correct because the ULS selector is missing images. Look in console |
|
A data point: it is looking for svgs, but the pngs are the only things there: http://whatcanidoforfedora.org/static/img/ |
|
Hmm. Shouldn't the SVGs be in there too? |
|
Yeah, you're right. It looks like I'll have to add the SVGs back in. |
Ah ha! You never committed them. They are ignored in the |
|
Mhm. Is there a reason why the SVGs are in the |
|
Added in 1f6615e |
To ignore the graphs produced by running |
|
It looks better now, but http://whatcanidoforfedora.org/static/img/world_map.svg is still missing. |
|
Added it in 6b9ad8d |
|
Looks good! Thanks @cydrobolt! |
static/global, builds to/static/