Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update message topics due to pkgdb update #255

Closed
tyll opened this issue May 27, 2014 · 1 comment · Fixed by fedora-infra/fedmsg_meta_fedora_infrastructure#146
Closed

update message topics due to pkgdb update #255

tyll opened this issue May 27, 2014 · 1 comment · Fixed by fedora-infra/fedmsg_meta_fedora_infrastructure#146

Comments

@tyll
Copy link
Contributor

tyll commented May 27, 2014

http://fedora-fedmsg.readthedocs.org/en/latest/topics.html#pkgdb does not mention pkgdb2 topics but only the no longer used pkgdb1 topics.
@ralphbean
Copy link
Contributor

That list of topics is generated from the test suite of https://github.com/fedora-infra/fedmsg_meta_fedora_infrastructure

The tests for now-retired pkgdb1 messages should have their name changed to include the string 'Legacy'. For instance, if TestPkgdbACLUpdate were renamed to TestLegacyPkgdbACLUpdate, it would no longer appear in the docs.

ralphbean added a commit to fedora-infra/fedmsg_meta_fedora_infrastructure that referenced this issue Sep 17, 2014
@ralphbean
Mark these pkgdb examples as Legacy
dbb15f7 
This needs scrutiny from @pypingou and @tyll.

By marking these tests as ``Legacy``, they will no longer show up in the
docs at http://fedora-fedmsg.readthedocs.org/en/latest/topics.html

In fedora-infra/fedmsg#255, @tyll mentioned that some pkgdb1 messages
still appeared in the docs even though they are not being broadcast
anymore.  I did my best to check that the topics of these messages that
I've marked do not actually appear in the pkgdb2 source, but I'd be much
more comfortable merging this if someone more familiar with the source
could look over them.

If merged, this fixes fedora-infra/fedmsg#255.
@ralphbean ralphbean mentioned this issue Sep 17, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Mark these pkgdb examples as Legacy fedora-infra/fedmsg_meta_fedora_infrastructure
2 participants
@tyll @ralphbean