This repository has been archived by the owner on Mar 6, 2024. It is now read-only.
Reviewers #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@@ -201,7 +218,8 @@ def decorated_function(*args, **kwargs): | |||
flask.flash( | |||
'You must be in one more group than the CLA', 'error') | |||
return flask.redirect(flask.url_for('index')) | |||
elif not is_nuancier_admin(flask.g.fas_user): | |||
elif not is_nuancier_admin(flask.g.fas_user) \ | |||
and not is_nuancier_reviewer(flask.g.fas_user): | |||
flask.flash('You are not an administrator of nuancier', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This error message is not quite accurate anymore..
I left two comments to just clean stuff up at the edges. Besides those, it looks good. :) |
This ought to be the most tested piece of code in the project :)
Cool -- 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.