Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Traceback in fedimg processor #268

Closed
ralphbean opened this issue May 12, 2015 · 2 comments · Fixed by fedora-infra/fedimg#27
Closed

Traceback in fedimg processor #268

ralphbean opened this issue May 12, 2015 · 2 comments · Fixed by fedora-infra/fedimg#27

Comments

@ralphbean
Copy link
Contributor

This message causes fedmsg_meta to traceback, like this:

  File "/usr/lib64/python2.6/threading.py", line 504 in __bootstrap
    self.__bootstrap_inner()
  File "/usr/lib64/python2.6/threading.py", line 532 in __bootstrap_inner
    self.run()
  File "/usr/lib64/python2.6/threading.py", line 484 in run
    self.__target(*self.__args, **self.__kwargs)
  File "/usr/lib64/python2.6/site-packages/twisted/python/threadpool.py", line 210 in _worker
    result = context.call(ctx, function, *args, **kwargs)
  File "/usr/lib64/python2.6/site-packages/twisted/python/context.py", line 59 in callWithContext
    return self.currentContext().callWithContext(ctx, func, *args, **kw)
  File "/usr/lib64/python2.6/site-packages/twisted/python/context.py", line 37 in callWithContext
    return func(*args,**kw)
  File "/usr/lib/python2.6/site-packages/moksha/hub/api/consumer.py", line 192 in _work
    self.log.exception(message)
Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/moksha/hub/api/consumer.py", line 190, in _work
    self.consume(message)
  File "/usr/lib/python2.6/site-packages/fedmsg/consumers/ircbot.py", line 319, in consume
    short=client.factory.short,
  File "/usr/lib/python2.6/site-packages/fedmsg/consumers/ircbot.py", line 270, in prettify
    subtitle = fedmsg.meta.msg2subtitle(msg, **self.hub.config)
  File "/usr/lib/python2.6/site-packages/fedmsg/meta/__init__.py", line 133, in __wrapper
    return f(msg, **config)
  File "/usr/lib/python2.6/site-packages/fedmsg/meta/__init__.py", line 152, in __wrapper
    return f(msg, processor=processor, **config)
  File "/usr/lib/python2.6/site-packages/fedmsg/meta/__init__.py", line 222, in msg2subtitle
    return processor.subtitle(msg, **config)
  File "/usr/lib/python2.6/site-packages/fedmsg_meta_fedora_infrastructure/fedimg.py", line 52, in subtitle
    ami = msg['msg']['extra']['id']
TypeError: 'NoneType' object is unsubscriptable

@oddshocks, this is in the latest fedimg code you were working on in #260. Can you have a look?
@ralphbean
Copy link
Contributor Author

Since this is causing datagrepper to traceback too, it's kind of hard to get the original message.

Here it is:

{
    "i": 3, 
    "msg": {
        "destination": "EC2 (ap-northeast-1)", 
        "extra": null, 
        "image_name": "Fedora-Cloud-Base-22-20150512.x86_64", 
        "image_url": "Fedora-Cloud-Base-22-20150512.x86_64", 
        "status": "started"
    }, 
    "msg_id": "2015-4ecd6855-edb8-4de1-999c-3219e24aef84", 
    "source_name": "datanommer", 
    "source_version": "0.6.5", 
    "timestamp": 1431464408.0, 
    "topic": "org.fedoraproject.prod.fedimg.image.test"
}

@dtgay dtgay mentioned this issue May 18, 2015
Merged
@dtgay
Copy link
Contributor

dtgay commented May 18, 2015

I think fedora-infra/fedimg#27 should be the fix we're looking for. Just an oversight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/fix fedmsg meta fedora-infra/fedimg
2 participants
@ralphbean @dtgay