Skip to content
This repository has been archived by the owner on Jan 14, 2021. It is now read-only.

Monitoring #97

Merged
merged 36 commits into from Oct 22, 2014
Merged

Monitoring #97

merged 36 commits into from Oct 22, 2014

Conversation

pypingou
Copy link
Member

No description provided.

pypingou and others added 30 commits October 21, 2014 13:14
@pypingou
Adjust the docstring of a method that's about Packages not Collections
1335012
@pypingou
Add a boolean for each package to flag them as something to monitor i…
50a8943 
…n anitya or not
@pypingou
Add method to the Package object to get the list of all the package t…
c7f3f88 
…o monitor
@pypingou
Add method to the internal API to retrieve the list of package to mon…
5c0bd06 
…itor
@pypingou
Add a new API endpoint listing the package to monitor
a9784a0
@pypingou
Add method to set the monitoring status of a package
46d3d55
@pypingou
Update the logging for monitor status update
b378d72
@pypingou
Add new API endpoint to set the monitoring status of a package
1fbfb4c
@pypingou
Add the alembic migration script to adjust the DB as required
cffa37f
@pypingou
It's sa.Boolean not sa.boolean
d23f355
@pypingou
Adjust the alembic migration script a little more
e89e943
@pypingou
Final alembic migration script update - it works
6ccc1fb
@trasher @pypingou
Toggle monitoring button
d4f16c5
@trasher @pypingou
Add link to wiki pages for users information
2ab17f3
@trasher @pypingou
Check if user is admin, package admin or commiter to enable switch bu…
03fad77 
…tton
@pypingou
Do not include the ACLs of the package in the fedmsg message sent
c928171
@pypingou
Make the branch argument on has_acls a keyword argument, optional
78021c7
@pypingou
Expand a little the unit-tests suite for pkgdb.lib.has_acls
62af40e
@pypingou
Make the has_acls method accept checking for several ACLs in one pass
27d7c12 
Adjust the documentation to make it clear that it checks if the user
has at least one of the ACL asked
@pypingou
Expand a little bit more the unit-test suite for pkgdb.lib.has_acls
9edeac9
@pypingou
Can change the monitoring flag: maintainer of the package and admins
ff2b2ff
@pypingou
If nothing changed, return a message saying so
2f9940a
@pypingou
Add unit-tests for the set_monitor_package on pkgdb.lib
56ab3c0
@pypingou
Check that the package exists before checking if the user is allowed …
37fd84d 
…to change it
@pypingou
Drop debugging statement
d30121d
@pypingou
Fix typo in docstring
d65f813
@pypingou
Add first unit-tests for /api/monitored
7cb6ea4
@pypingou
Support setting the monitor flag in the Package's constructor
7a82070
@pypingou
Fix generating the JSON for the JSON output of /api/monitored
3021d2d
@pypingou
Set up the kernel package as being monitored
56c148c 
This way we have something to test against
ralphbean
ralphbean reviewed Oct 22, 2014
View reviewed changes
pkgdb2/api/extras.py
@API.route('/monitored')
def api_monitored():
'''
List package monitored
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should package(s) be plural?

@pypingou
Copy link
Member Author

I think these last two commits are fixing all your remarks :)

@ralphbean
Copy link
Contributor

Cool, 👍

@ralphbean ralphbean closed this Oct 22, 2014
@ralphbean ralphbean reopened this Oct 22, 2014
pypingou added a commit that referenced this pull request Oct 22, 2014
@pypingou
Merge pull request #97 from fedora-infra/monitoring
5e93885 
Monitoring
@pypingou pypingou merged commit 5e93885 into master Oct 22, 2014
@pypingou
Copy link
Member Author

Thanks for the review!

@pypingou pypingou deleted the monitoring branch October 22, 2014 17:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pypingou @ralphbean @trasher