This repository has been archived by the owner on Jul 24, 2018. It is now read-only.
Don't return prematurely. #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It made it so that as soon as one rule matched for one user, the whole tamale would evaluate to true for every subsequent user. This incorrectly made it so that users would suddenly start getting all kinds of messages not relevant to them; messages would be directed at 40+ users simultaneously, one after another, after another.
|
Took me a little bit to see the diff, but 👍 |
Yeah! It was super confusing to me :( Thanks for the review! |
ralphbean
added a commit
that referenced
this pull request
Aug 15, 2014
…t-release Don't return prematurely.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It made it so that as soon as one rule matched for one user, the whole
tamale would evaluate to true for every subsequent user. This incorrectly
made it so that users would suddenly start getting all kinds of messages
not relevant to them; messages would be directed at 40+ users
simultaneously, one after another, after another.