Don't return prematurely if parent task is still open. #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@robert-scheck hit this here: fedora-infra/fmn#54 (comment) There is a parent build which had one task: That task had three child tasks srpmfromscm buildarch tagbuild All three grandchild tasks were done and koji published a fedmsg message about it, but the middle-parent task had not yet become 'closed'. FMN tried to get the 'results' of the middle-parent task, but when that task is still 'open', this throws an exception. We can handle that exception, but we returned prematurely from the ``_fill_task_template`` method, returning before we had a chance to iterate over the grandchild tasks that have the most interesting information (binary rpms, logs, etc). This patch should avoid that premature return so we can cram as much info as is available in our emails.
|
Cool for me 👍 |
ralphbean
added a commit
that referenced
this pull request
Mar 2, 2015
Don't return prematurely if parent task is still open.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@robert-scheck hit this here:
fedora-infra/fmn#54 (comment)
All three grandchild tasks were done and koji published a fedmsg message
about it, but the middle-parent task had not yet become 'closed'. FMN
tried to get the 'results' of the middle-parent task, but when that task
is still 'open', this throws an exception.
We can handle that exception, but we returned prematurely from the
_fill_task_templatemethod, returning before we had a chance toiterate over the grandchild tasks that have the most interesting
information (binary rpms, logs, etc).
This patch should avoid that premature return so we can cram as much
info as is available in our emails.