Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Searching for "mod_*" includes "mod*" #86

Closed
robert-scheck opened this issue Feb 21, 2015 · 4 comments · Fixed by #103
Closed

Searching for "mod_*" includes "mod*" #86

robert-scheck opened this issue Feb 21, 2015 · 4 comments · Fixed by #103
Assignees
@pypingou

Comments

@robert-scheck
Copy link

When searching for mod_* I also get all results for mod* - this doesn't feel right to me.
@pypingou
Copy link
Member

Apparently mod\_* works better but it also surprises me a little

@pypingou
Copy link
Member

Amusingly mod_p* does work as expected...

@pypingou
Copy link
Member

So it seems that underscore is a special character for LIKE queries [1] as we are using here, so this behavior makes sense and I am not sure we should change it

[1] http://www.postgresql.org/docs/8.3/static/functions-matching.html

@ralphbean
Copy link
Contributor

It seems to me like we shouldn't make postgres' special characters matter to users at all.
That's a database specific thing. We shouldn't expect users to know database-specific things about our apps, so I'm 👍 on changing it.

@pypingou pypingou mentioned this issue Feb 25, 2015
Merged
@pypingou pypingou self-assigned this Feb 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pypingou pypingou

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

On postgresql '_' is a special character that we should escape fedora-infra/anitya
3 participants
@ralphbean @pypingou @robert-scheck