Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Anonymize anonymous comments over fedmsg. #111

Merged
merged 1 commit into from Nov 11, 2014
Merged

Conversation

ralphbean
Copy link
Contributor

@pypingou
Copy link
Member

pypingou commented Nov 9, 2014

👍

@ralphbean
Copy link
Contributor Author

Just a note, the same kind of change here needs to be made against the pyramid branch. I'll take care of that.

ralphbean added a commit that referenced this pull request Nov 10, 2014
Just like #111 does for bodhi1.

A new magic map is added for all models that can be used elsewhere
called ``__anonymity_map__``: a dict that allows conditionally scrubbing
fields from JSON responses if ``anonymize`` is set to ``True``.

Currently, this is only fleshed out and tested for the ``Comment``
model, but I don't think we have a need to extend it anywhere else.
@ralphbean
Copy link
Contributor Author

Will wait for @lmacken to take a look at this one before merging, just to be sure this and the bodhi2 approach are agreeable to him.

@lmacken
Copy link
Contributor

lmacken commented Nov 11, 2014

Looks great, thanks @ralphbean ! 🍵

lmacken added a commit that referenced this pull request Nov 11, 2014
Anonymize anonymous comments over fedmsg.
@lmacken lmacken merged commit fc1dfa9 into develop Nov 11, 2014
@lmacken lmacken deleted the feature/anonymize branch November 11, 2014 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bodhi datagrepper leaks email address
3 participants