Some mailman fixes. #167
Merged
Some mailman fixes. #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # Just in case we couldn't convert them to a username (they don't exist, | ||
| # for instance), then we chop up their email to 'look like' a username | ||
| # anyways.. best effort. | ||
| return username.split('@')[0] |
There was a problem hiding this comment.
but wouldn't say, ralph@microsoft.com get the attribution then? (ie: should we just drop the username if it still contains a '@' after email2fas?)
There was a problem hiding this comment.
Eh, good point. Thanks!
|
One question, otherwise 👍 |
|
OK. 1462354 should address your comment. |
|
👍 for me :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exciting, now that I see @abompard poking the lists: https://apps.fedoraproject.org/datagrepper/raw?category=mailman