This repository has been archived by the owner on Jan 14, 2021. It is now read-only.
Rework the monitoring flag #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should help reduce the code duplication
…o the user's actions
|
The new UI:
|
| @@ -156,6 +156,13 @@ a.wheel, a.wheel:hover, button.wheel, button.wheel:hover { | |||
| background-position: 3px 50%; | |||
| } | |||
|
|
|||
| label.active, label.active:hover { | |||
| background-image: url(https://admin.fedoraproject.org/pkgdb/static/arrow.png) !important; | |||
There was a problem hiding this comment.
They are hard-coded for all the css, the only other option is to hard-code them as /pkgdb/static/....
We can't use flask's magic in the CSS files :(
There was a problem hiding this comment.
I could swear you can do them relative to the css file.
There was a problem hiding this comment.
Yeah, see here how fedmenu does it?
|
👍 from me (except for that background-image url -- can that be changed?) |
|
Adjusted :) |
|
👍 Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replace the two states flag with a three states one:
This should fix #187
As a side effect, of the new UI, I believe this will also fix #163