Skip to content
This repository has been archived by the owner on Jan 14, 2021. It is now read-only.

branch orphan packages #95

Closed
tyll opened this issue Oct 7, 2014 · 7 comments
Closed

branch orphan packages #95

tyll opened this issue Oct 7, 2014 · 7 comments
Labels
easyfix

Comments

@tyll
Copy link
Contributor

tyll commented Oct 7, 2014

pulseaudio-equalizer has no F21 branch, but a master and F20/F19 branches, probably because it was not branched since it is orphaned:

https://admin.fedoraproject.org/pkgdb/package/pulseaudio-equalizer/
https://admin.fedoraproject.org/pkgdb/admin/log/?package=pulseaudio-equalizer

However, it is still shipped in F21, therefore there should be a branch.
@pypingou
Copy link
Member

By curiosity, when do we drop orphaned packages? After branching?

In other words, is it really logical to branch a package that has no-one to maintain it?

@tyll
Copy link
Contributor Author

tyll commented Oct 23, 2014

On Thu, Oct 23, 2014 at 06:25:10AM -0700, Pierre-Yves Chibon wrote:

By curiosity, when do we drop orphaned packages? After branching?

In other words, is it really logical to branch a package that has no-one to maintain it?

Previously orphaned packages were retired shortly before branching, but
only after maintainers had time to adopt them. Currently packages
orphaned for 6 weeks will be retired, so it is possible that a package
will be retired after it was branched.

@pypingou
Copy link
Member

Ok, tagging as easyfix as this is a one-line patch :)

@codenamesubho
Copy link
Contributor

I would like to fix this bug. I have already setup pkgdb2. Can you guide me as how to solve this bug?

@pypingou
Copy link
Member

@ghost-script cool, thanks for stepping up.

The fix is a single line change, on the part of the code cloning a branch into another one. Feel free to check the file pkgdb2_branch.py in the utility folder as a starting point.

@codenamesubho
Copy link
Contributor

@pypingou i read the file pkgd2_branch.py and follwed the trail to add_branch() method in pkgdb2/lib/__init__.py. I think for now we clone 'Approved' packages only.
https://github.com/fedora-infra/pkgdb2/blob/master/pkgdb2/lib/__init__.py#L1494

A Fix might be to check for 'Approved' or 'Orphaned' packages.

codenamesubho added a commit to codenamesubho/pkgdb2 that referenced this issue Oct 26, 2014
@codenamesubho
BugFix-fedora-infra#95 branch orphan packages
f109a86 
Added check for 'Orphaned' packages while cloning to new branch.
pypingou added a commit that referenced this issue Oct 27, 2014
@pypingou
Merge pull request #102 from Ghost-script/master
cda40d2 
BugFix-#95 branch orphan packages
@pypingou
Copy link
Member

Merged, thus this ticket is fixed, thanks @ghost-script !

ralphbean pushed a commit to ralphbean/releng that referenced this issue Nov 12, 2015
@tyll
find_unblocked_orphans: Handle pkgdb2 errors
9bea796 
Packages Fedora Branched without a branch for Fedora Branched cause an
error when getting maintainer information. However, this should never
happen:
fedora-infra/pkgdb2#95
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
easyfix
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tyll @pypingou @codenamesubho