Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow to specify timestamps with msg_ids #147

Closed
tyll opened this issue Aug 7, 2014 · 4 comments
Closed

allow to specify timestamps with msg_ids #147

tyll opened this issue Aug 7, 2014 · 4 comments

Comments

@tyll
Copy link

tyll commented Aug 7, 2014

It would be nice if I could query to get all messages that were after and before certain message ids, example: get all messages that were sent after 2014-44e4f7c5-bdef-436b-bb4a-523bc78ed890 but before 2014-311cad36-0633-4e0d-b40b-9c22408d7826.
@ralphbean
Copy link
Contributor

Yes, good idea. :)

@sayanchowdhury
Copy link
Contributor

@ralphbean I was working on this. Here is the changes I made - sayanchowdhury@1a6efea
Can you verify the code and the approach i took?
It takes start_id and end_id as GET parameters in the URL and returns all messages between them including the start and the end messages

@pypingou
Copy link
Member

pypingou commented Oct 9, 2014

The approach looks fine to me, could we expand it to support having only a start_id or an end_id?

Something like: give me the messages after start_id=XXX, I guess we could make it so that it behaves like the default query to raw/

@ralphbean
Copy link
Contributor

Can you verify the code and the approach i took?

Yes, it looks good to me too. :)

give me the messages after start_id=XXX

This would also be nice, yes.

@sayanchowdhury sayanchowdhury mentioned this issue Oct 12, 2014
Merged
ralphbean added a commit that referenced this issue Oct 13, 2014
@ralphbean
Merge pull request #155 from sayanchowdhury/gh-147
c8d2df3 
Filter messages between two msg_ids
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tyll @ralphbean @sayanchowdhury @pypingou