Create git repo on fedora review server for every new package: issue #4 #5

fluffybeing · 2015-03-18T22:27:23Z

@abompard @pypingou I have created a new function create_git_repo which get called up when any new package get added on the review server. It then create a git repository in folder specified on the config file and also adds the default spec file to it.
For e.g.
When user "foo" add a package named "bar" for review then a git repo get created in the folder /var/git/foo/bar.git with bar.spec file in it.

pypingou · 2015-03-19T08:25:37Z

fresque/lib/views.py

@@ -77,6 +82,14 @@ def newpackage(db, method, data, username):
        else:
            result.flash.append(("Package successfully created!", "success"))
            result.redirect = ('package', {"name": pkg.name})
+
+            # create spec template using package infrormation
+            data = create__spec_template(pkg.name, pkg.summary)


Stupid question, but is there a reason for the two _ there?

@pypingou sorry I haven't observed it.

fluffybeing · 2015-03-23T18:03:21Z

@pypingou removed the spec file addition.

fluffybeing · 2015-03-24T09:13:35Z

@pypingou @abompard The changes made is working fine. Here is the link to the snapshots I had captured for the repository on client as well as server side.
http://cl.ly/image/362W1R1R032F
http://cl.ly/image/340d0f1j0S0s

ralphbean · 2015-03-25T12:37:38Z

fresque/lib/views.py

+    '''
+    gitrepo = os.path.join(gitfolder, '%s.git' % name)
+    if os.path.exists(gitrepo):
+        raise 'The project repo "%s" already exists' % name


Instead of raising a bare string, can you raise an exception with that string as its message? i.e.,

raise IOError('The project repo "%s" already exists' % name)

Other than this change, this set of changes looks pretty good to me.

update requirements.txt remove extra underscore remove dummy spec file update create_git_repo method

fluffybeing · 2015-03-26T05:26:29Z

@ralphbean updated 👍

pypingou · 2015-03-26T06:41:03Z

@rahulrrixe did you forget to push? I do not see the change here.

fluffybeing · 2015-03-26T07:22:22Z

@pypingou it is already updated, I have squashed the commits.

pypingou · 2015-03-26T07:49:52Z

Indeed, I see it now, must have been a cache issue PEBKAC :)

fluffybeing · 2015-03-26T10:04:25Z

@pypingou is anything else needed for this PR?

pypingou · 2015-04-05T17:03:59Z

fresque/lib/views.py

        else:
            result.flash.append(("Package successfully created!", "success"))
            result.redirect = ('package', {"name": pkg.name})
+
+            # Add git repo creation message
+            if create_git_repo(pkg.name, gitfolder):


What if the folder does not exist?

-- Nevermind it's handled below :)

Yeah, the IOError is not handled, in case of error the user will just see an error 500 page. It would be better to catch the exception and handle it.
Plus, the "if" construct here is strange, the create_git_repo function does not return True or False. It's a very C-like way of writing code ;-) Better use try/except/else.

@rahulrrixe ping - any response to the feedback here?

Hi @ralphbean @abompard, I have made required changes as you have suggested. Sorry for the delay as I was traveling.

pypingou · 2015-04-05T17:04:43Z

Looks good to me, I'll let @abompard have the final word :)

ralphbean · 2015-05-07T15:28:52Z

@abompard, can you take a look at this?

fluffybeing · 2015-05-24T18:56:24Z

@abompard I think I should create a separate file for git operation in /lib directory. What is your view on this?

pypingou · 2015-06-23T15:30:15Z

fresque/__init__.py


 APP = flask.Flask(__name__)
+APP.jinja_env.trim_blocks = True
+APP.jinja_env.lstrip_blocks = True


You may want to consider if you want this or not (project wide, you can also do it locally for loop or if) as it may make the html produced quite un-readable

@pypingou our application will not get large number of requests for now and so I don't think we need this much of optimization on cost of readability.

I tend to agree which is why I brought the question :)

…file"

fluffybeing · 2015-06-25T20:17:48Z

@pypingou I have removed the split_ref.

pypingou · 2015-07-01T08:21:21Z

fresque/templates/git/file.html

@@ -0,0 +1,83 @@
+{% extends 'layout.html' %} {% import 'macros.html' as macros %} {% block git %} {% include "/git/git_layout.html" %} {% endblock %} {% block content%}


You can split this line over multiple lines, it will make it easier to read

pypingou · 2015-08-05T08:57:53Z

fresque/default_config.py

@@ -21,7 +21,7 @@
 # secret key used to generate unique csrf token
 SECRET_KEY = 'Change-me-Im-famous'

-## If the authentication method is `fas`:
+# If the authentication method is `fas`:
 # To log in, the user must be a member of one of these groups
 REQUIRED_GROUPS = ('packager', 'provenpackager')


Note: I don't think we'll need provenpackager, but we will need a way to know if someone is a sponsor and that might require a change either in Ipsilon or in flask-fas-openid.

Can we add new group in flask-fas-openid?

Well, it's not about new group, it's about the status of someone in that group (user, sponsor, administrator)

fluffybeing · 2015-08-05T18:19:44Z

@abompard everything is fine now 👍

Create git repo on fedora review server for every new package: issue #4

abompard · 2015-08-05T19:26:27Z

Thanks Rahul.

fluffybeing force-pushed the git-integeration branch from bdf2a7a to 458a3bd Compare March 18, 2015 22:30

fluffybeing changed the title ~~Create git repo on fedora review server for every new package~~ Create git repo on fedora review server for every new package: issue #4 Mar 18, 2015

fluffybeing mentioned this pull request Mar 18, 2015

Create local git repository for the new package #4

Open

pypingou reviewed Mar 19, 2015
View reviewed changes

fluffybeing force-pushed the git-integeration branch 2 times, most recently from e1633d0 to fd8bb18 Compare March 23, 2015 18:01

ralphbean reviewed Mar 25, 2015
View reviewed changes

git repo creation after package name got added

3928385

update requirements.txt remove extra underscore remove dummy spec file update create_git_repo method

fluffybeing force-pushed the git-integeration branch from fd8bb18 to 3928385 Compare March 26, 2015 05:23

pypingou reviewed Apr 5, 2015
View reviewed changes

fluffybeing added 2 commits May 15, 2015 00:59

add exception handling for creating git repository

20427d6

add flash message in tuple and remove else condition

aff2810

fluffybeing added 7 commits May 26, 2015 02:14

add decode func to decode pygit blobs

59bd0a1

pygit repository basic operation

10bbd73

get the latest commit

097bde0

remove Repostory instantiation line

9bdd131

add chardet as dependecy

c062f49

add methods get commit diff and patch

48f25d5

completed basic repo tree view

9d98bb4

pypingou reviewed Jun 23, 2015
View reviewed changes

fluffybeing added 3 commits June 24, 2015 15:28

remove trimblock and lstrip jinja env to improve readability

49437e8

add link to the git web in package view file

30e6c06

Remove docutils as we don't need readme and add href for to view raw …

0e399ee

…file"

fluffybeing force-pushed the git-integeration branch from eb0c9d6 to 0e399ee Compare June 25, 2015 09:46

fluffybeing added 3 commits June 25, 2015 15:37

add path to identifier and filename to avoid breaking url mapping

a52eb7b

show tree view if clicked on a folder

cd3c85c

remove split_ref and simplify view_raw_file controller

9f6a925

pypingou reviewed Jul 1, 2015
View reviewed changes

fluffybeing added 6 commits July 2, 2015 11:29

remove extra imports and correct indentation

c989a5d

add custom exception classes

1aec7c2

add indentation to jinja templates for readability

31b83e4

add pygments as dependency

1c19c45

add proper spacing to methods

223d6d5

add six urllib_parse for py3 support

1031183

pypingou reviewed Aug 5, 2015
View reviewed changes

fluffybeing added 3 commits August 5, 2015 14:42

remove extra import statement

ef1ad96

remove merge conflicts

4918ce6

fix merge conflict due to six import

b21e65b

abompard added a commit that referenced this pull request Aug 5, 2015

Merge pull request #5 from rahulrrixe/git-integeration

93af9b9

Create git repo on fedora review server for every new package: issue #4

abompard merged commit 93af9b9 into fedora-infra:master Aug 5, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create git repo on fedora review server for every new package: issue #4 #5

Create git repo on fedora review server for every new package: issue #4 #5

fluffybeing commented Mar 18, 2015

pypingou Mar 19, 2015

fluffybeing Mar 19, 2015

fluffybeing commented Mar 23, 2015

fluffybeing commented Mar 24, 2015

ralphbean Mar 25, 2015

ralphbean Mar 25, 2015

fluffybeing commented Mar 26, 2015

pypingou commented Mar 26, 2015

fluffybeing commented Mar 26, 2015

pypingou commented Mar 26, 2015

fluffybeing commented Mar 26, 2015

pypingou Apr 5, 2015

abompard May 7, 2015

ralphbean May 14, 2015

fluffybeing May 14, 2015

pypingou commented Apr 5, 2015

ralphbean commented May 7, 2015

fluffybeing commented May 24, 2015

pypingou Jun 23, 2015

fluffybeing Jun 23, 2015

pypingou Jun 23, 2015

fluffybeing commented Jun 25, 2015

pypingou Jul 1, 2015

pypingou Aug 5, 2015

fluffybeing Aug 5, 2015

pypingou Aug 5, 2015

fluffybeing commented Aug 5, 2015

abompard commented Aug 5, 2015

		@@ -0,0 +1,83 @@
		{% extends 'layout.html' %} {% import 'macros.html' as macros %} {% block git %} {% include "/git/git_layout.html" %} {% endblock %} {% block content%}

Create git repo on fedora review server for every new package: issue #4 #5

Create git repo on fedora review server for every new package: issue #4 #5

Conversation

fluffybeing commented Mar 18, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fluffybeing commented Mar 23, 2015

fluffybeing commented Mar 24, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fluffybeing commented Mar 26, 2015

pypingou commented Mar 26, 2015

fluffybeing commented Mar 26, 2015

pypingou commented Mar 26, 2015

fluffybeing commented Mar 26, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pypingou commented Apr 5, 2015

ralphbean commented May 7, 2015

fluffybeing commented May 24, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fluffybeing commented Jun 25, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

fluffybeing commented Aug 5, 2015

abompard commented Aug 5, 2015