Skip to content
This repository has been archived by the owner on Jul 24, 2018. It is now read-only.

Feature/group maintainer #16

Merged
merged 9 commits into from Aug 21, 2014
Merged

Feature/group maintainer #16

merged 9 commits into from Aug 21, 2014

Conversation

pypingou
Copy link
Member

No description provided.

@pypingou
Copy link
Member Author

I'm opening this pull-request also to start the discussion.

In _get_pkgdb2_packagers_for we are considering every person having at least one ACL, should we restrict it to the person having commit ACL?

@pypingou
Copy link
Member Author

The present code is missing the logic to create/instantiate the FAS client

'''

if not hasattr(_cache, 'backend'):
cache.configure(**config['fmn.rules.cache'])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need a reference to the config object here.

@ralphbean
Copy link
Contributor

In _get_pkgdb2_packagers_for we are considering every person having at least one ACL, should we restrict it to the person having commit ACL?

Well, what are the other ACLs? 'watch'? If a user has a watch ACL then they probably want fmn to notify them also. OTOH, this could be expanded to be more configurable.

@pypingou
Copy link
Member Author

In _get_pkgdb2_packagers_for we are considering every person having at least one ACL, should we >> restrict it to the person having commit ACL?

Well, what are the other ACLs? 'watch'? If a user has a watch ACL then they probably want fmn to notify
them also. OTOH, this could be expanded to be more configurable.

Fair enough yeah :)

@ralphbean
Copy link
Contributor

Let's test it! Is there a package out there that is owned by infra-sig but not by one of us?

@pypingou
Copy link
Member Author

Let's test it! Is there a package out there that is owned by infra-sig but not by one of us?

Bochecha is part of the infra-sig group but has no ACLs on any of the package the group has I think

@ralphbean
Copy link
Contributor

Ah, this doesn't actually work. The code you added gets called by get_packagers_of_package, but nothing actually calls that function. It stopped being used back in 664a27f

@pypingou
Copy link
Member Author

I was fearing this.

I'll try to think of the opposite approach

ralphbean added a commit to fedora-infra/fmn.consumer that referenced this pull request Aug 21, 2014
...just like we do for pkgdb ownership info.

This relies on the code introduced in fedora-infra/fmn.rules#16.
ralphbean added a commit that referenced this pull request Aug 21, 2014
@ralphbean ralphbean merged commit ea438e7 into develop Aug 21, 2014
@ralphbean ralphbean deleted the feature/group_maintainer branch August 21, 2014 15:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants