Skip to content
This repository has been archived by the owner on Jan 14, 2021. It is now read-only.

Fix excluding provenpackager from some packages specified in the configuration #164

Merged
merged 2 commits into from Feb 24, 2015

Conversation

pypingou
Copy link
Member

No description provided.

@ralphbean
Copy link
Contributor

This change is being made to a very confusing piece of code. From IRC:

threebean: what is 'pkg' ?
threebean: is it a list of fixed length?
   pingou: threebean: it is yes, retrieved from the db
threebean: what do the elements represent?
threebean: I ask because it's confusing to read with all the 'pkg[0]' and 'pkg[2]' stuff all over the place
threebean: like, "if pkg[2] not in output[pkg[0]]:"  who knows what that means..
threebean: can we change the vcs_acls code in pkgs2/lib/__init__ to read like
threebean: 'for package_name, username, branchname in pkgs:'
threebean: it's a lot more code change than is proposed in this PR
threebean: but I don't think I can actually review it :P  not without pen and paper
   pingou: I need to backport this in prod, so I'd like to keep this as small as possible

That said, the change looks sane enough, so 👍 as is. I'll file another issue to clean up the code path.

pypingou added a commit that referenced this pull request Feb 24, 2015
Fix excluding provenpackager from some packages specified in the configuration
@pypingou pypingou merged commit dc6b45b into master Feb 24, 2015
@pypingou pypingou deleted the fix_exclude_pp branch February 24, 2015 21:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants