Spec URL: http://ralph.fedorapeople.org//nodejs-vow.spec SRPM URL: http://ralph.fedorapeople.org//nodejs-vow-0.4.4-1.fc20.src.rpm Description: A Promises/A+ implementation.
Review: + mock build is successful for f22 - rpmlint output on rpms gave nodejs-vow.x86_64: E: no-binary nodejs-vow.x86_64: W: only-non-binary-in-usr-lib nodejs-vow.x86_64: W: no-documentation nodejs-vow-debuginfo.x86_64: E: empty-debuginfo-package 3 packages and 0 specfiles checked; 2 errors, 2 warnings. ==> See suggestion below + Source verified with upstream as (sha256sum) srpm tarball :55c8f128424d2bb61baf3b586804b7b3adfdb6cb7a99340f5b228a251c47eb59 upstream tarball :55c8f128424d2bb61baf3b586804b7b3adfdb6cb7a99340f5b228a251c47eb59 + License is valid and included as thier upstream links in source file. + rest looks following packaging guidelines suggestions: 1) Add following to spec BuildArch: noarch %if 0%{?fedora} >= 19 ExclusiveArch: %{nodejs_arches} noarch %else ExclusiveArch: %{ix86} x86_64 %{arm} noarch %endif 2) just found new upstream release 0.4.5 Please provide updated package
New release including the latest upstream tarball. Spec URL: http://threebean.org/rpm/SPECS/nodejs-vow.spec SRPM URL: http://threebean.org/rpm/SRPMS/nodejs-vow-0.4.5-1.fc20.src.rpm
Thanks for the update. New srpm looks good. APPROVED.
New Package SCM Request ======================= Package Name: nodejs-vow Short Description: Promises/A+ proposal compatible promises library Upstream URL: https://npmjs.org/package/vow Owners: ralph Branches: f21,f20,f19,epel7,el6 InitialCC:
Git done (by process-git-requests).
nodejs-vow-0.4.5-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-vow-0.4.5-1.fc20
nodejs-vow-0.4.5-1.fc19 has been submitted as an update for Fedora 19. https://admin.fedoraproject.org/updates/nodejs-vow-0.4.5-1.fc19
nodejs-vow-0.4.5-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/nodejs-vow-0.4.5-1.el6
Buildroot overrides have been created.
nodejs-vow-0.4.5-1.el6 has been pushed to the Fedora EPEL 6 stable repository.
nodejs-vow-0.4.5-1.fc20 has been pushed to the Fedora 20 stable repository.
nodejs-vow-0.4.5-1.fc19 has been pushed to the Fedora 19 stable repository.