This repository has been archived by the owner on Jul 24, 2018. It is now read-only.
Cache the results of rules for each message. #10
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
..then dispose of that cache once we're finished with each message.
A typical rule is "is this a koji message?" Say we have 500 users, for
every message that comes in we're going to call that function 500 * 2 times
(once for email and once for IRC). This builds a little cache at the
beginning of processing each message where we can store that result and
re-use it for each user/context. We then throw it away and start over when
we're done processing that message.
Also:
Instantiate rule code_paths at load-time instead of consume-time.