Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/build the comps repo for mash #98

Merged
merged 11 commits into from Oct 8, 2014
Merged

Update/build the comps repo for mash #98

merged 11 commits into from Oct 8, 2014

Conversation

lmacken
Copy link
Contributor

@lmacken lmacken commented Oct 7, 2014

#97

@lmacken
Copy link
Contributor Author

lmacken commented Oct 8, 2014

Good call. We actually had this happen the other day in production. It killed the push, and I had to go fix comps. https://git.fedorahosted.org/cgit/comps.git/commit/?id=ad4ee524170531335e19960dde0323be9f6148a7

I just tweaked the MasherThread.cmd to raise an exception with any non-zero errorcode.

@ralphbean
Copy link
Contributor

Tight. 👍 here.

@lmacken
Copy link
Contributor Author

lmacken commented Oct 8, 2014

We definitely want to fail loudly, as broken xml hitting the mirrors can cause many client-side issues.

@lmacken
Copy link
Contributor Author

lmacken commented Oct 8, 2014

Thanks dude! :)

lmacken added a commit that referenced this pull request Oct 8, 2014
Update/build the comps repo for mash
@lmacken lmacken merged commit a1c861f into pyramid Oct 8, 2014
@lmacken lmacken deleted the feature/comps branch October 8, 2014 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants