Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/updateinfo #75

Merged
merged 41 commits into from Jul 24, 2014
Merged

feature/updateinfo #75

merged 41 commits into from Jul 24, 2014

Conversation

lmacken
Copy link
Contributor

@lmacken lmacken commented Jul 23, 2014

This is a port of the bodhi.metadata module that generates the updateinfo.xml that is injected into the yum repodata with bodhi.modifyrepo.

@lmacken
Add the current bodhi1 metadata.py
9f14105
@lmacken
Copy over the bodhi1 modifyrepo.py for now
ef06772
@lmacken
Update the license on the metadata module
56962b9
@lmacken
Port the metadata module to the new model
31a36c5
@lmacken
Use a proper tempfile for the pkgdb tag db
6b00443
@lmacken
Determine the tag from the release & request instead of the mash conf…
db2e9f3 
…ig file

This also adds a few new arguments to the ExtendedMetadata constructor
@lmacken
Whitespace tweaks to the metadata module
79a6589
@lmacken
The RepositoryNotFound exception has been removed
0d74f1b
@lmacken
Default to the global mash config
d351db2
@lmacken
Initial port of the basic metadata test
e96c233
@lmacken
Update some DevBuildsys defaults to work with the metadata tests
818bdba
@lmacken
Use the mashers logger
a482c7b
@lmacken
Allow our tests to change build tags with the DevBuildsys
14a907d
@lmacken
Revert "Update some DevBuildsys defaults to work with the metadata te…
b7052f5 
…sts"

This reverts commit 818bdba.
@lmacken
Generate the updateinfo in the masher
5ce37cb
@lmacken
Create the repodir if it doesn't exist
ab37cbb
@lmacken
Log that we are generating a testing digest
6fa5121
@lmacken
Remove an unnecessary return statement
55c1a35
@lmacken
Clean up a conditional
a4caffa
@lmacken
Clean up the pkgtags exception handler
9b51c64
@lmacken
Pretend the update is in testing before generating the updateinfo
b6946fc
@lmacken
Add a tearDown to the metadata tests
6fbffba
@lmacken
Use UpdateMetadata.get_notices instead of get_notice in the tests.
8a742ae 
The get_notice method looks for the nvr in the filenames of the notice, which
are currently not consistent in our testing environment with the current
DevBuildsys. Work around it for now by indexing into all of them.
@lmacken
Don't fetch the pkgtags db during the tests
fe3b9bc
@lmacken
Test extended metadata updating
9fc57ad
@lmacken
PEP8
8ded654
@lmacken
Let us mock out koji.listBuildRPMs results in the DevBuildsys
a8c2005
@lmacken
s/print/log.debug
ece2e32
@lmacken
Add an ExtendedMetadata.cache_repodata method
747440b
@lmacken
PEP8
d8310d3
ralphbean
ralphbean reviewed Jul 24, 2014
View reviewed changes
bodhi/metadata.py


class ExtendedMetadata(object):

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a docstring here? A paragraph or two to help the reader know what kind of metadata they're looking at. Is this yum metadata? how does this get used? Is it called upon at update submission time? at mash time? What kinds of things rely on it? If it breaks, is it nbd or is it really bad?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

docstring added!

@ralphbean
Copy link
Contributor

This is so tight. 👍

@bochecha
Copy link
Contributor

If we deploy on RHEL 7, then we likely won't need the modifyrepo. 😉

@lmacken
Copy link
Contributor Author

lmacken commented Jul 24, 2014

I'm definitely in favor of focusing on RHEL7+ so we can finally ditch bodhi.modifyrepo and use createrepo's.

Testing this locally, I'm hitting this:

raceback (most recent call last):
  File "/home/lmacken/code/github.com/bodhi/bodhi/tests/test_metadata.py", line 102, in test_extended_metadata
    md.insert_updateinfo()
  File "/home/lmacken/code/github.com/bodhi/bodhi/metadata.py", line 340, in insert_updateinfo
    repomd.add(self.doc)
  File "/usr/share/createrepo/modifyrepo.py", line 125, in add
    if self.compress:
AttributeError: RepoMetadata instance has no attribute 'compress'

@bochecha
Copy link
Contributor

Do you have to set that attribute yourself on the object?

Also, I just thought about one thing: with the move to createrepo_c, how does that leave us? 😕

@lmacken
Copy link
Contributor Author

lmacken commented Jul 24, 2014

Setting the attribute(s) leads me down a rabbit hole of failure. I'm just going to merge what I've got for now, and hopefully someday we can work with upstream createrepo's modifyrepo.

With regards to createrepo_c, I'm not sure. Hopefully nothing will change from a bodhi perspective, and most of the change will be isolated to mash.

lmacken added a commit that referenced this pull request Jul 24, 2014
@lmacken
Merge pull request #75 from fedora-infra/feature/updateinfo
d0431c3 
updateinfo.xml metadata support ported from bodhi1
@lmacken lmacken merged commit d0431c3 into pyramid Jul 24, 2014
@lmacken lmacken deleted the feature/updateinfo branch July 24, 2014 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lmacken @ralphbean @bochecha