Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a more detailed koji build completed filter #54

Closed
nirik opened this issue Feb 21, 2015 · 10 comments · Fixed by fedora-infra/fedmsg_meta_fedora_infrastructure#210
Closed

Add a more detailed koji build completed filter #54

nirik opened this issue Feb 21, 2015 · 10 comments · Fixed by fedora-infra/fedmsg_meta_fedora_infrastructure#210

Comments

@nirik
Copy link
Member

nirik commented Feb 21, 2015

The old koji mails sent something like:

Package: ansible-1.8.3-1.el7
Tag: epel7-testing-candidate
Status: complete
Built by: kevin
ID: 612324
Started: Tue, 17 Feb 2015 23:39:49 UTC
Finished: Tue, 17 Feb 2015 23:41:56 UTC
Changelog:

  • Tue Feb 17 2015 Kevin Fenzi kevin@scrye.com 1.8.3-1
  • Update to 1.8.3
  • Sun Jan 11 2015 Toshio Kuratomi toshio@fedoraproject.org - 1.8.2-3
  • Work around a bug in python2.6 by using simplejson (applies in EPEL6)
  • Wed Dec 17 2014 Michael Scherer misc@zarb.org 1.8.2-2
  • precreate /etc/ansible/roles and /usr/share/ansible_plugins

SRPMS:
ansible-1.8.3-1.el7.src.rpm

Closed tasks:

Task 8973189 on buildhw-04.phx2.fedoraproject.org
Task Type: buildArch (ansible-1.8.3-1.el7.src.rpm, noarch)
logs:
http://koji.fedoraproject.org/koji/getfile?taskID=8973189&name=build.log
http://koji.fedoraproject.org/koji/getfile?taskID=8973189&name=mock_output.log
http://koji.fedoraproject.org/koji/getfile?taskID=8973189&name=root.log
http://koji.fedoraproject.org/koji/getfile?taskID=8973189&name=state.log
rpms:
http://kojipkgs.fedoraproject.org//packages/ansible/1.8.3/1.el7/noarch/ansible-1.8.3-1.el7.noarch.rpm

Task 8973158 on buildhw-11.phx2.fedoraproject.org
Task Type: buildSRPMFromSCM (/ansible:7c6e5edbc6bdbd2d30e159e2923d1ba617e58a44)
logs:
http://koji.fedoraproject.org/koji/getfile?taskID=8973158&name=build.log
http://koji.fedoraproject.org/koji/getfile?taskID=8973158&name=checkout.log
http://koji.fedoraproject.org/koji/getfile?taskID=8973158&name=mock_output.log
http://koji.fedoraproject.org/koji/getfile?taskID=8973158&name=root.log
http://koji.fedoraproject.org/koji/getfile?taskID=8973158&name=state.log

Task 8973199 on arm02-builder15.arm.fedoraproject.org
Task Type: tagBuild (noarch)

The new build completed just gives a link to the build.
Might be nice to have a 'detailed build complete' filter if possible?
@ralphbean
Copy link

Totally possible. There's a little API designed to be filled out with stuff like this.

Thanks for filing!

@robert-scheck
Copy link

It would be also great if the subject could get more verbose again (mention the tag):

Old: Package: phpMyAdmin-4.3.10-1.fc20 Tag: f20-updates-candiate Status: complete Built by: robert
New: robert's phpMyAdmin-4.3.10-1.fc20 completed

This was referenced Feb 23, 2015
Closed
Merged
@robert-scheck
Copy link

I am sorry, this is not really solved:

robert's php53-tcpdf-6.2.4-1.el5 completed

Package:    php53-tcpdf-6.2.4-1.el5
Status:     complete
Built by:   robert
ID:         616079
Started:    Fri, 27 Feb 2015 21:26:44 UTC
Finished:   Fri, 27 Feb 2015 21:28:17 UTC

Closed tasks:
-------------
Task 9095043 on buildvm-13.phx2.fedoraproject.org
Task Type: build (noarch)
Link: https://koji.fedoraproject.org/koji/taskinfo?taskID=9095043

Task 9095043 is not finished

        http://koji.fedoraproject.org/koji/buildinfo?buildID=616079

I would love to see all the other direct links and information again...

@ralphbean
Copy link

What links are you talking about?

@ralphbean
Copy link

Wait. Something is wrong here. The top portions say that the build is completed. But the tasks say that the task is not yet closed. That.. is wrong, you're right.

@ralphbean
Copy link

@robert-scheck can you give us the headers for that email? Specifically, when was it sent?

ralphbean added a commit to fedora-infra/fedmsg_meta_fedora_infrastructure that referenced this issue Feb 28, 2015
@ralphbean
Don't return prematurely if parent task is still open.
1f80bf7 
@robert-scheck hit this here:
fedora-infra/fmn#54 (comment)

There is a parent build which had one task:
   That task had three child tasks
        srpmfromscm
        buildarch
        tagbuild

All three grandchild tasks were done and koji published a fedmsg message
about it, but the middle-parent task had not yet become 'closed'.  FMN
tried to get the 'results' of the middle-parent task, but when that task
is still 'open', this throws an exception.

We can handle that exception, but we returned prematurely from the
``_fill_task_template`` method, returning before we had a chance to
iterate over the grandchild tasks that have the most interesting
information (binary rpms, logs, etc).

This patch should avoid that premature return so we can cram as much
info as is available in our emails.
@ralphbean ralphbean mentioned this issue Feb 28, 2015
Merged
@robert-scheck
Copy link 

Date: Fri, 27 Feb 2015 21:29:41 +0000 (UTC)

and

Received: by bastion01.phx2.fedoraproject.org (Postfix)
        id 4CC74604CD8A; Fri, 27 Feb 2015 21:29:41 +0000 (UTC)
Delivered-To: robert@fedoraproject.org
Received: from notifs-backend01.phx2.fedoraproject.org (notifs-backend01.phx2.fedoraproject.org [10.5.126.168])
        by bastion01.phx2.fedoraproject.org (Postfix) with ESMTP id 423D7604CD79
        for <robert@fedoraproject.org>; Fri, 27 Feb 2015 21:29:41 +0000 (UTC)

@ralphbean
Copy link

@robert-scheck, I'm pretty sure this is the result of a race-condition between FMN and koji. The code in fedora-infra/fedmsg_meta_fedora_infrastructure#214 should fix it.

@robert-scheck
Copy link

@ralphbean, I don't think this has been really solved so far when seeing this a few minutes ago:

Package:    phpMyAdmin-4.3.12-1.fc23
Status:     complete
Built by:   robert
ID:         620363
Started:    Sat, 14 Mar 2015 17:09:39 UTC
Finished:   Sat, 14 Mar 2015 17:11:03 UTC

Closed tasks:
-------------
Task 9233490 on buildvm-14.phx2.fedoraproject.org
Task Type: build (noarch)
Link: https://koji.fedoraproject.org/koji/taskinfo?taskID=9233490

Task 9233490 is not finished

        http://koji.fedoraproject.org/koji/buildinfo?buildID=620363

@ralphbean
Copy link

Ah, the code-change hasn't yet been released or deployed.

jeremycline pushed a commit to jeremycline/fmn that referenced this issue Dec 7, 2016
@ralphbean
Merge pull request fedora-infra#54 from sayanchowdhury/irc-notifications
f75c571 
Add feature to get categories, filters, rules in the IRC backend itself
jeremycline pushed a commit to jeremycline/fmn that referenced this issue Dec 7, 2016
@ralphbean
Merge pull request fedora-infra#54 from fedora-infra/feature/cache-sl…
d1298c8 
…ow-re2-compilation

Cache slow python-re2 compilation.
jeremycline pushed a commit to jeremycline/fmn that referenced this issue Dec 7, 2016
@ralphbean
Merge pull request fedora-infra#54 from acatton/multiple-rules
2ec0665 
Specify the rule_id when deleting or negating a rule
jeremycline pushed a commit that referenced this issue Apr 26, 2017
@ralphbean
Merge pull request #54 from fedora-infra/feature/confirmation
0f067a9 
Add confirmation dialogs for all our "delete" actions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement a long-form value for koji builds. fedora-infra/fedmsg_meta_fedora_infrastructure
3 participants
@ralphbean @nirik @robert-scheck