Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a long-form value for koji builds. #210

Merged
merged 5 commits into from Feb 24, 2015

Conversation

ralphbean
Copy link
Contributor

This should fix fedora-infra/fmn#54.

@classmethod
def _fill_build_template(cls, session, build):
full_build = session.getBuild(build['build_id'])
lookup = dict(zip(*zip(*koji.BUILD_STATES.items())[::-1]))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this fail if the import of koji failed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. :)

@pypingou
Copy link
Member

Cool, many thanks sir! 👍

ralphbean added a commit that referenced this pull request Feb 24, 2015
Implement a long-form value for koji builds.
@ralphbean ralphbean merged commit c60343c into develop Feb 24, 2015
@ralphbean ralphbean deleted the feature/koji-longform branch February 24, 2015 15:13
@pypingou
Copy link
Member

Still 👍 for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a more detailed koji build completed filter
2 participants