Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAF (ABRT server) processor with tests #259

Merged
merged 1 commit into from Apr 27, 2015
Merged

Conversation

mbrysa
Copy link
Contributor

@mbrysa mbrysa commented Apr 24, 2015

No description provided.

@mbrysa mbrysa mentioned this pull request Apr 24, 2015
@ralphbean
Copy link
Contributor

Looks good :) I have two suggestions:

  • Can you make the __icon__ on the processor and the expected_icon on the test be this: https://apps.fedoraproject.org/packages/images/icons/abrt.png
  • Can you make the secondary_icon be https://apps.fedoraproject.org/packages/images/icons/{package}.png where {package} is the name of the first package in the components list?

This will make the messages end up looking nicer in the datagrepper feed. If you have other better ideas for the icons, by all means use those.

@mbrysa
Copy link
Contributor Author

mbrysa commented Apr 27, 2015

Good suggestions, updated.

@ralphbean
Copy link
Contributor

Good stuff. 👍 to merge.

ralphbean added a commit that referenced this pull request Apr 27, 2015
FAF (ABRT server) processor with tests
@ralphbean ralphbean merged commit 19cc66e into fedora-infra:develop Apr 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants